DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	dev@dpdk.org, Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com
Subject: Re: [PATCH v2 00/16] replace __atomic operations returning new value
Date: Thu, 16 Mar 2023 09:17:05 -0700	[thread overview]
Message-ID: <20230316161705.GA8277@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <13221889.uLZWGnKmhe@thomas>

On Thu, Mar 16, 2023 at 04:25:41PM +0100, Thomas Monjalon wrote:
> 16/03/2023 11:03, Bruce Richardson:
> > On Wed, Mar 15, 2023 at 02:15:29PM -0700, Tyler Retzlaff wrote:
> > > This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with
> > > __atomic_fetch_{add,and,or,sub,xor} intrinsics where the new value
> > > is used.
> [...]
> > > Tyler Retzlaff (16):
> > >   app/test: use previous value atomic fetch operations
> > >   common/cnxk: use previous value atomic fetch operations
> > >   common/mlx5: use previous value atomic fetch operations
> > >   drivers/event: use previous value atomic fetch operations
> > >   net/af_xdp: use previous value atomic fetch operations
> > >   net/cnxk: use previous value atomic fetch operations
> > >   net/cxgbe: use previous value atomic fetch operations
> > >   net/iavf: use previous value atomic fetch operations
> > >   net/mlx5: use previous value atomic fetch operations
> > >   net/octeontx: use previous value atomic fetch operations
> > >   raw/ifpga: use previous value atomic fetch operations
> > >   bbdev: use previous value atomic fetch operations
> > >   eal: use previous value atomic fetch operations
> > >   ipsec: use previous value atomic fetch operations
> > >   mbuf: use previous value atomic fetch operations
> > >   rcu: use previous value atomic fetch operations
> > > 
> > I am wondering how we go about ensuring that we don't introduce any more of
> > these atomic_X_fetch intrinsics. Is there some way we can add a compiler
> > warning for them or have a checkpatch check, for example?
> 
> In devtools/checkpatches.sh, we are checking for these patterns:
> 	rte_atomic[0-9][0-9]_.*\(
> 	__atomic_thread_fence\(
> 
> Feel free to add more "forbidden patterns".
> 
> 

yes, i was going to do this before end of week but got interrupted by
other work. i will introduce a patch for checkpatches.sh standalone
asap that can be merged before these changes.

  reply	other threads:[~2023-03-16 16:17 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 22:15 [PATCH 00/16] use " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 02/16] common/cnxk: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 03/16] common/mlx5: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 04/16] drivers/event: " Tyler Retzlaff
2023-03-13  7:02   ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-03-10 22:15 ` [PATCH 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 06/16] net/cnxk: " Tyler Retzlaff
2023-03-13  6:45   ` [EXT] " Nithin Kumar Dabilpuram
2023-03-10 22:15 ` [PATCH 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 08/16] net/iavf: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 09/16] net/mlx5: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 10/16] net/octeontx: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 12/16] bbdev: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 13/16] eal: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 14/16] ipsec: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 15/16] mbuf: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 16/16] rcu: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 00/16] replace __atomic operations returning new value Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 02/16] common/cnxk: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 03/16] common/mlx5: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 04/16] drivers/event: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 06/16] net/cnxk: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 08/16] net/iavf: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 09/16] net/mlx5: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 10/16] net/octeontx: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 12/16] bbdev: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 13/16] eal: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 14/16] ipsec: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 15/16] mbuf: " Tyler Retzlaff
2023-03-15 21:15   ` [PATCH v2 16/16] rcu: " Tyler Retzlaff
2023-03-16 10:03   ` [PATCH v2 00/16] replace __atomic operations returning new value Bruce Richardson
2023-03-16 15:25     ` Thomas Monjalon
2023-03-16 16:17       ` Tyler Retzlaff [this message]
2023-04-18 18:11         ` Tyler Retzlaff
2023-03-20 10:24   ` Ruifeng Wang
2023-03-20 19:00 ` [PATCH v3 " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 02/16] common/cnxk: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 03/16] common/mlx5: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 04/16] drivers/event: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 06/16] net/cnxk: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 08/16] net/iavf: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 09/16] net/mlx5: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 10/16] net/octeontx: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 12/16] bbdev: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 13/16] eal: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 14/16] ipsec: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 15/16] mbuf: " Tyler Retzlaff
2023-03-20 19:00   ` [PATCH v3 16/16] rcu: " Tyler Retzlaff
2023-04-25  9:10   ` [PATCH v3 00/16] replace __atomic operations returning new value David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230316161705.GA8277@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).