From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 562FD41EBE; Fri, 17 Mar 2023 17:25:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1327B42F98; Fri, 17 Mar 2023 17:25:24 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 8BBD040395 for ; Fri, 17 Mar 2023 17:25:22 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id j3-20020a17090adc8300b0023d09aea4a6so9681836pjv.5 for ; Fri, 17 Mar 2023 09:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1679070321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EYxOSr1BBXGlJjLMev32aIaRAxZkLNGALn1kIo/RTz8=; b=F2RuW9FBksrtxMfea2hSVUznFdV1+B1HbBMr7msnPCW+IeueFllKUHGV2sVBtsUnry pym8UNuc7feY3Ndt1zlfJ3Blxl0SG4b+UnBB1g/AVX1pH8oON4efsqZkqnolJusPbSNg qq9uSGMSBEDf6Bdbr6RSvqv9iMUu+nuCBRmUyktgrf70vLFezvfVWPqcsVc8sDBvGcKG agocKCSH+ajZeiTKl2oyLK781sDsSPDRKvE++oxCQnu2SyrIv97P34l5sLYfz5GXxVKG iZz+2vsY20HGpNzm41yOHh/2nR87N6yo3l5iGbWFEJyoj0X6AEqECd1t4KjDRtiMjG4j dSiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679070321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EYxOSr1BBXGlJjLMev32aIaRAxZkLNGALn1kIo/RTz8=; b=J+/mDFfBkpJGAsTJia4cNwMZg7XhYTCFYKCZy6CC/47tata8Kqo8RnuCn/xsA3PYFP sWhGrWKYM1JudPgtfm5a35pbwtDzhQLICU3tDc5mXOUc8lDLdEm6f1Wiq0K+a7JCCjwQ dlUawSUgEO021l/QS9MuPlxlRs7QlPGOGMLttC/Vauwtn1Xv1mUaOidNt+XCPhX2nasF B6nvCPahCjxiIaGTAt671YHQUMgJr/R+XZzGgBPddpEpKrIXlg2pJsv8HqaSS7hGokaV 0mz7vI47OftV538LXc1vhC0xnhaXC00AfnwSlm8GjIHWuiG9H+dSlrsG1SxCv6UQODsH 1hzA== X-Gm-Message-State: AO0yUKXZri3mpWAAwYuV3Ud1iIxRcNbubr9M5viYODZYJAB2EErlICPy oByGkuyrh2tJMbtD8pF677eVbQ== X-Google-Smtp-Source: AK7set+PkMwjc1sS6uemf5SR7mzheBG1YR2iwe4OaqUxNG6TSjX2kT/bZ8uUcngSsS4WL5EUOj88yQ== X-Received: by 2002:a17:902:d709:b0:1a1:98a9:406f with SMTP id w9-20020a170902d70900b001a198a9406fmr4310378ply.67.1679070321612; Fri, 17 Mar 2023 09:25:21 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id k2-20020a170902e90200b0019c919bccf8sm1770177pld.86.2023.03.17.09.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 09:25:21 -0700 (PDT) Date: Fri, 17 Mar 2023 09:25:19 -0700 From: Stephen Hemminger To: Olivier Matz Cc: dev@dpdk.org Subject: Re: [PATCH v4 2/2] testpmd: enable interrupt in interactive mode Message-ID: <20230317092519.3ce0ac7c@hermes.local> In-Reply-To: References: <20230313171905.67720-1-stephen@networkplumber.org> <20230315173132.4044-1-stephen@networkplumber.org> <20230315173132.4044-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 17 Mar 2023 17:20:59 +0100 Olivier Matz wrote: > On Wed, Mar 15, 2023 at 10:31:32AM -0700, Stephen Hemminger wrote: > > The setting in terminal handling for both Unix style and > > Windows was not ensuring that Ctrl-C character would > > cause interrupt. > > > > This is a first release bug. Testpmd interactive mode has > > always disabled control-c handling on Linux. > > This was a design choice, not a bug. This design choice is discussable > today (at that time, dpdk was also running in baremetal without signals > or interrupt). The idea was to behave like a shell, i.e. ctrl-c just > clears the current line. > > We may want to change this behavior (I remember an old discussion where > Bruce stated that he would prefer ctrl-c to kill the program), but it > will have an impact on all cmdline users, so to me it has to be > announced. Ok, my motivation was to be able to test interrupt in testpmd interactive mode. Without this change, it requires sending SIGINT from another process. Plus almost all programs that have an interactive mode accept control-c to interrupt. I split this patch off since it doesn't impact the bugfix around testpmd and interrupts.