From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB020427E0; Mon, 20 Mar 2023 10:29:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 59EA742D32; Mon, 20 Mar 2023 10:28:18 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 40C3442C4D for ; Mon, 20 Mar 2023 10:28:06 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Pg8Wr6wg3zrVPV; Mon, 20 Mar 2023 17:27:04 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 17:28:03 +0800 From: Chengwen Feng To: , , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Dawid Gorecki , Guy Tzalik CC: Subject: [PATCH v2 12/44] net/ena: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:20:38 +0000 Message-ID: <20230320092110.37295-13-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys'. Fixes: cc0c5d251928 ("net/ena: make Tx completion timeout configurable") Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/ena/ena_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index efcb163027..82a6c75824 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -3444,6 +3444,9 @@ static int ena_process_uint_devarg(const char *key, char *str_end; uint64_t uint_value; + if (value == NULL) + return -EINVAL; + uint_value = strtoull(value, &str_end, 10); if (value == str_end) { PMD_INIT_LOG(ERR, @@ -3482,6 +3485,9 @@ static int ena_process_bool_devarg(const char *key, struct ena_adapter *adapter = opaque; bool bool_value; + if (value == NULL) + return -EINVAL; + /* Parse the value. */ if (strcmp(value, "1") == 0) { bool_value = true; -- 2.17.1