From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6107F427E0; Mon, 20 Mar 2023 10:29:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19C0242D52; Mon, 20 Mar 2023 10:28:24 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 1ABBE42B7E for ; Mon, 20 Mar 2023 10:28:09 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Pg8Wx03dGzrVPZ; Mon, 20 Mar 2023 17:27:09 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 17:28:07 +0800 From: Chengwen Feng To: , , Yuying Zhang , Beilei Xing , John McNamara , Zhe Tao , Jingjing Wu , Xiaolong Ye , Qi Zhang , Alvin Zhang , Wei Dai CC: Subject: [PATCH v2 15/44] net/i40e: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:20:41 +0000 Message-ID: <20230320092110.37295-16-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys'. Fixes: 79f2248219c0 ("net/i40e: add floating VEB option") Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") Fixes: 56270b4208ab ("net/i40e: limit the number of VF messages") Fixes: ee653bd80044 ("net/i40e: determine number of queues per VF at run time") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/i40e/i40e_ethdev.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 371f42233e..1338b9b92d 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -829,6 +829,9 @@ floating_veb_list_handler(__rte_unused const char *key, int min, max; bool *vf_floating_veb = opaque; + if (floating_veb_value == NULL) + return -EINVAL; + while (isblank(*floating_veb_value)) floating_veb_value++; @@ -921,6 +924,9 @@ i40e_check_floating_handler(__rte_unused const char *key, const char *value, __rte_unused void *opaque) { + if (value == NULL) + return -EINVAL; + if (strcmp(value, "1")) return -1; @@ -1258,6 +1264,9 @@ i40e_parse_multi_drv_handler(__rte_unused const char *key, pf = (struct i40e_pf *)opaque; + if (value == NULL) + return -EINVAL; + errno = 0; support_multi_driver = strtoul(value, &end, 10); if (errno != 0 || end == value || *end != 0) { @@ -1347,6 +1356,9 @@ read_vf_msg_config(__rte_unused const char *key, { struct i40e_vf_msg_cfg *cfg = opaque; + if (value == NULL) + return -EINVAL; + if (sscanf(value, "%u@%u:%u", &cfg->max_msg, &cfg->period, &cfg->ignore_second) != 3) { memset(cfg, 0, sizeof(*cfg)); @@ -4693,6 +4705,9 @@ static int i40e_pf_parse_vf_queue_number_handler(const char *key, pf = (struct i40e_pf *)opaque; RTE_SET_USED(key); + if (value == NULL) + return -EINVAL; + errno = 0; num = strtoul(value, &end, 0); if (errno != 0 || end == value || *end != 0) { -- 2.17.1