From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B502427E0; Mon, 20 Mar 2023 10:29:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E234B42D5E; Mon, 20 Mar 2023 10:28:26 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 8A46F42D13 for ; Mon, 20 Mar 2023 10:28:09 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Pg8Wx3h1HzrVNM; Mon, 20 Mar 2023 17:27:09 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 17:28:08 +0800 From: Chengwen Feng To: , , Qiming Yang , Qi Zhang , Zhichao Zeng , Haiyue Wang , Ray Kinsella CC: Subject: [PATCH v2 17/44] net/ice: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:20:43 +0000 Message-ID: <20230320092110.37295-18-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys'. Fixes: 9e984bc53bc9 ("net/ice: add option to disable ACL engine in DCF") Fixes: 7564d5509611 ("net/ice: add DCF hardware initialization") Fixes: 603beeb970b5 ("net/ice: add safe mode devarg") Fixes: 79d559de896b ("net/ice: add option for setting HW debug mask") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/ice/ice_dcf_ethdev.c | 6 ++++++ drivers/net/ice/ice_ethdev.c | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index dcbf2af5b0..9fe712ebd1 100644 --- a/drivers/net/ice/ice_dcf_ethdev.c +++ b/drivers/net/ice/ice_dcf_ethdev.c @@ -1933,6 +1933,9 @@ static int ice_dcf_engine_disabled_handler(__rte_unused const char *key, const char *value, __rte_unused void *opaque) { + if (value == NULL) + return -EINVAL; + if (strcmp(value, "off")) return -1; @@ -1943,6 +1946,9 @@ static int ice_dcf_cap_check_handler(__rte_unused const char *key, const char *value, __rte_unused void *opaque) { + if (value == NULL) + return -EINVAL; + if (strcmp(value, "dcf")) return -1; diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 9a88cf9796..0917d20515 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -1887,6 +1887,9 @@ parse_bool(const char *key, const char *value, void *args) char *end; int num; + if (value == NULL) + return -EINVAL; + num = strtoul(value, &end, 10); if (num != 0 && num != 1) { @@ -1906,6 +1909,9 @@ parse_u64(const char *key, const char *value, void *args) u64 *num = (u64 *)args; u64 tmp; + if (value == NULL) + return -EINVAL; + errno = 0; tmp = strtoull(value, NULL, 16); if (errno) { -- 2.17.1