From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61928427E0; Mon, 20 Mar 2023 10:32:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F3FA42FC0; Mon, 20 Mar 2023 10:29:03 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 279EC42D32 for ; Mon, 20 Mar 2023 10:28:16 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Pg8Vb4m6gzKsJG; Mon, 20 Mar 2023 17:25:59 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 17:28:14 +0800 From: Chengwen Feng To: , , Harry van Haaren , Bruce Richardson , Jerin Jacob , Radu Nicolau CC: Subject: [PATCH v2 42/44] event/sw: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:21:08 +0000 Message-ID: <20230320092110.37295-43-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys'. Fixes: aaa4a221da26 ("event/sw: add new software-only eventdev driver") Fixes: 70207f35e21f ("event/sw: improve performance") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- drivers/event/sw/sw_evdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index cfd659d774..524a84c244 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -875,6 +875,8 @@ static int assign_numa_node(const char *key __rte_unused, const char *value, void *opaque) { int *socket_id = opaque; + if (value == NULL) + return -EINVAL; *socket_id = atoi(value); if (*socket_id >= RTE_MAX_NUMA_NODES) return -1; @@ -885,6 +887,8 @@ static int set_sched_quanta(const char *key __rte_unused, const char *value, void *opaque) { int *quanta = opaque; + if (value == NULL) + return -EINVAL; *quanta = atoi(value); if (*quanta < 0 || *quanta >= 4096) return -1; @@ -895,6 +899,8 @@ static int set_credit_quanta(const char *key __rte_unused, const char *value, void *opaque) { int *credit = opaque; + if (value == NULL) + return -EINVAL; *credit = atoi(value); if (*credit < 0 || *credit >= 128) return -1; @@ -905,6 +911,8 @@ static int set_deq_burst_sz(const char *key __rte_unused, const char *value, void *opaque) { int *deq_burst_sz = opaque; + if (value == NULL) + return -EINVAL; *deq_burst_sz = atoi(value); if (*deq_burst_sz < 0 || *deq_burst_sz > SCHED_DEQUEUE_MAX_BURST_SIZE) return -1; @@ -915,6 +923,8 @@ static int set_min_burst_sz(const char *key __rte_unused, const char *value, void *opaque) { int *min_burst_sz = opaque; + if (value == NULL) + return -EINVAL; *min_burst_sz = atoi(value); if (*min_burst_sz < 0 || *min_burst_sz > SCHED_DEQUEUE_MAX_BURST_SIZE) return -1; @@ -925,6 +935,8 @@ static int set_refill_once(const char *key __rte_unused, const char *value, void *opaque) { int *refill_once_per_call = opaque; + if (value == NULL) + return -EINVAL; *refill_once_per_call = atoi(value); if (*refill_once_per_call < 0 || *refill_once_per_call > 1) return -1; -- 2.17.1