From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4C18A427E0;
Mon, 20 Mar 2023 10:32:23 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4797B42FCC;
Mon, 20 Mar 2023 10:29:04 +0100 (CET)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
by mails.dpdk.org (Postfix) with ESMTP id A554842D3E
for <dev@dpdk.org>; Mon, 20 Mar 2023 10:28:16 +0100 (CET)
Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.54])
by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Pg8Tg6VzKz17MZV;
Mon, 20 Mar 2023 17:25:11 +0800 (CST)
Received: from localhost.localdomain (10.50.163.32) by
dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.21; Mon, 20 Mar 2023 17:28:15 +0800
From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Jakub Palider
<jpalider@marvell.com>, Tomasz Duszynski <tduszynski@marvell.com>, Jerin
Jacob <jerinj@marvell.com>
CC: <dev@dpdk.org>
Subject: [PATCH v2 44/44] raw/cnxk_gpio: fix segment fault when parse devargs
Date: Mon, 20 Mar 2023 09:21:10 +0000
Message-ID: <20230320092110.37295-45-fengchengwen@huawei.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com>
References: <20230314124813.39521-1-fengchengwen@huawei.com>
<20230320092110.37295-1-fengchengwen@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.50.163.32]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse input args with 'only keys'.
Fixes: d0b8a4e19131 ("raw/cnxk_gpio: add GPIO driver skeleton")
Fixes: ecc0dd455e9a ("raw/cnxk_gpio: add option to select subset of GPIOs")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
drivers/raw/cnxk_gpio/cnxk_gpio.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index e2907c18b5..5a28e307d2 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -67,6 +67,9 @@ cnxk_gpio_parse_arg_gpiochip(const char *key __rte_unused, const char *value,
{
long val;
+ if (value == NULL)
+ return -EINVAL;
+
errno = 0;
val = strtol(value, NULL, 10);
if (errno)
@@ -81,6 +84,9 @@ static int
cnxk_gpio_parse_arg_allowlist(const char *key __rte_unused, const char *value,
void *extra_args __rte_unused)
{
+ if (value == NULL)
+ return -EINVAL;
+
allowlist = strdup(value);
if (!allowlist)
return -ENOMEM;
--
2.17.1