From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB9E2427E0; Mon, 20 Mar 2023 10:32:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6DDF42B7E; Mon, 20 Mar 2023 10:30:42 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id A988742B7E; Mon, 20 Mar 2023 10:30:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679304624; x=1710840624; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=YFh5onNsc2FRBNujN7zG0XWj5v0Sw6XGNEuiTB4J/9g=; b=QrS3bieQxkQIDCj0VaaIGvuzkU9hgwFl8qa+TI7IwzDEA8YBKmi0q6l0 lXl4VJIz6DNmn7TbWZg7lyusSjsdDofP2kaY/Y/8NdH1CvZliKLBwj5CO lPujQh3XTgqU2w040aah8pStTsFI0NzhyT+NO8fJ+424MycAmTuR3y7X4 Hv6YJyAYdPvNw8Yg0Ql/SUMc6qG4CSA3V88Gen+IBG1V3hPKPLxRwa8R6 KUQaOIQi1d+ueCHNCssQLdMGkAUvqZLjNdieLpYtL41kFC2v4nmMIZ4Pc 8kaP1/PWL5NTe97tP6R7OBFpyNkY+4GNhOnTv1TGmG0SeFNQLD6lqPoxd w==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="322457466" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="322457466" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 02:30:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="855224998" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="855224998" Received: from unknown (HELO silpixa00400902.ir.intel.com) ([10.243.23.111]) by orsmga005.jf.intel.com with ESMTP; 20 Mar 2023 02:30:08 -0700 From: Saoirse O'Donovan To: Thomas Monjalon , Akhil Goyal , Fan Zhang Cc: dev@dpdk.org, Saoirse O'Donovan , stable@dpdk.org, declan.doherty@intel.com Subject: [PATCH] test/crypto: fix errors for test stats testcase Date: Mon, 20 Mar 2023 09:29:56 +0000 Message-Id: <20230320092956.8576-1-saoirse.odonovan@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The test stats testcase was printing the same error message for multiple errors in the test stats testcase. This is now replaced with descriptive error messages, which match the cause of the failure. Fixes: 202d375 ("app/test: add cryptodev unit and performance tests") Cc: stable@dpdk.org Cc: declan.doherty@intel.com Signed-off-by: Saoirse O'Donovan --- .mailmap | 1 + app/test/test_cryptodev.c | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.mailmap b/.mailmap index 4018f0fc47..f61972b63d 100644 --- a/.mailmap +++ b/.mailmap @@ -1175,6 +1175,7 @@ Sangjin Han Sankar Chokkalingam Santoshkumar Karanappa Rastapur Santosh Shukla +Saoirse O'Donovan Saori Usami Sarath Somasekharan Sarosh Arif diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index af3d89b9c7..59cf3ec40f 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -12335,11 +12335,11 @@ test_stats(void) TEST_ASSERT((stats.enqueued_count == 1), "rte_cryptodev_stats_get returned unexpected enqueued stat"); TEST_ASSERT((stats.dequeued_count == 1), - "rte_cryptodev_stats_get returned unexpected enqueued stat"); + "rte_cryptodev_stats_get returned unexpected dequeued stat"); TEST_ASSERT((stats.enqueue_err_count == 0), - "rte_cryptodev_stats_get returned unexpected enqueued stat"); + "rte_cryptodev_stats_get returned unexpected enqueued error count stat"); TEST_ASSERT((stats.dequeue_err_count == 0), - "rte_cryptodev_stats_get returned unexpected enqueued stat"); + "rte_cryptodev_stats_get returned unexpected dequeued error count stat"); /* invalid device but should ignore and not reset device stats*/ rte_cryptodev_stats_reset(ts_params->valid_devs[0] + 300); @@ -12347,7 +12347,7 @@ test_stats(void) &stats), "rte_cryptodev_stats_get failed"); TEST_ASSERT((stats.enqueued_count == 1), - "rte_cryptodev_stats_get returned unexpected enqueued stat"); + "rte_cryptodev_stats_get returned unexpected enqueued stat after invalid reset"); /* check that a valid reset clears stats */ rte_cryptodev_stats_reset(ts_params->valid_devs[0]); @@ -12355,9 +12355,9 @@ test_stats(void) &stats), "rte_cryptodev_stats_get failed"); TEST_ASSERT((stats.enqueued_count == 0), - "rte_cryptodev_stats_get returned unexpected enqueued stat"); + "rte_cryptodev_stats_get returned unexpected enqueued stat after valid reset"); TEST_ASSERT((stats.dequeued_count == 0), - "rte_cryptodev_stats_get returned unexpected enqueued stat"); + "rte_cryptodev_stats_get returned unexpected dequeued stat after valid reset"); return TEST_SUCCESS; } -- 2.25.1