DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: <hfli@netitest.com>
Cc: <dev@dpdk.org>
Subject: Re: 回复: af_packet can't send packet more than framecnt
Date: Mon, 20 Mar 2023 09:53:42 -0700	[thread overview]
Message-ID: <20230320095342.756879fb@hermes.local> (raw)
In-Reply-To: <1CCF1B14C9842CED+002501d95b20$272f1b60$758d5220$@netitest.com>

On Mon, 20 Mar 2023 19:36:02 +0800
<hfli@netitest.com> wrote:

> Hi,
> 
> The issue has been resolved when I patched new code from dpdk 22.12, my dpdk
> version is 19.11
> 
> Index: rte_eth_af_packet.c
> ===================================================================
> --- rte_eth_af_packet.c (版本 44115)
> +++ rte_eth_af_packet.c (版本 44128)
> @@ -169,6 +169,29 @@
>  }
>  
>  /*
> + * Check if there is an available frame in the ring
> + */
> +static inline int
> +tx_ring_status_available(uint32_t tp_status)
> +{
> +       /*
> +        * We eliminate the timestamp status from the packet status.
> +        * This should only matter if timestamping is enabled on the socket,
> +        * but there is a bug in the kernel which is fixed in newer
> releases.
> +        *
> +        * See the following kernel commit for reference:
> +        *     commit 171c3b151118a2fe0fc1e2a9d1b5a1570cfe82d2
> +        *     net: packetmmap: fix only tx timestamp on request


Thanks for investigating, what kernel are you using?
That bug was fixed in 5.13 kernel (in 2021-05-11) almost 2 years ago.
It looks like it was also fixed in the LTS stable kernels.

DPDK probably should not be modified to handle kernel bugs that are
ready fixed in the current kernel LTS versions.

  reply	other threads:[~2023-03-20 16:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 11:36 hfli
2023-03-20 16:53 ` Stephen Hemminger [this message]
2023-03-21  1:00   ` 回复: " hfli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230320095342.756879fb@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=hfli@netitest.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).