From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8779A427E1; Mon, 20 Mar 2023 13:18:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77A1A410F3; Mon, 20 Mar 2023 13:18:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6BE91410F3 for ; Mon, 20 Mar 2023 13:18:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679314726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iJaZEYz6XAzYupWfaQsfSpL6yaVBivodpNyD/Ctpk7o=; b=E7TEPR5N/YSn8IW/UCUDtHbma3tdwYw57YOEa5lQjtnmkrFYPpqe0zthStQyB4LU2uubjU aG490VLZ4Zzk9Sim+lbtyN2cPpUoDITYTg84J5J1QnDw3XzcKVU6pF/BbqbqULSmN7AsuY FauOUhDYlmPi0jnaHhNoW+tx4HuHbSc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-_mbf8-_lPLqf6vnLXGSC1Q-1; Mon, 20 Mar 2023 08:18:42 -0400 X-MC-Unique: _mbf8-_lPLqf6vnLXGSC1Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D07C3815F68; Mon, 20 Mar 2023 12:18:42 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91C4040C83AC; Mon, 20 Mar 2023 12:18:41 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Aaron Conole , Michael Santana Subject: [PATCH v2 2/2] ci: test compilation with debug in GHA Date: Mon, 20 Mar 2023 13:18:33 +0100 Message-Id: <20230320121833.1385859-2-david.marchand@redhat.com> In-Reply-To: <20230320121833.1385859-1-david.marchand@redhat.com> References: <20230320102624.1258816-1-david.marchand@redhat.com> <20230320121833.1385859-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org We often miss compilation issues with -O0 -g. Switch to debug in GHA for the gcc job. Signed-off-by: David Marchand --- Changes since v1: - rather than introduce a new job, updated the ABI check job to build with debug, --- .ci/linux-build.sh | 8 +++++++- .github/workflows/build.yml | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index ab0994388a..150b38bd7a 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -65,6 +65,12 @@ if [ "$RISCV64" = "true" ]; then cross_file=config/riscv/riscv64_linux_gcc fi +buildtype=debugoptimized + +if [ "$BUILD_DEBUG" = "true" ]; then + buildtype=debug +fi + if [ "$BUILD_DOCS" = "true" ]; then OPTS="$OPTS -Denable_docs=true" fi @@ -85,7 +91,7 @@ fi OPTS="$OPTS -Dplatform=generic" OPTS="$OPTS -Ddefault_library=$DEF_LIB" -OPTS="$OPTS -Dbuildtype=debugoptimized" +OPTS="$OPTS -Dbuildtype=$buildtype" OPTS="$OPTS -Dcheck_includes=true" if [ "$MINI" = "true" ]; then OPTS="$OPTS -Denable_drivers=net/null" diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 154be70cc1..bbcb535afb 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -18,6 +18,7 @@ jobs: ABI_CHECKS: ${{ contains(matrix.config.checks, 'abi') }} ASAN: ${{ contains(matrix.config.checks, 'asan') }} BUILD_32BIT: ${{ matrix.config.cross == 'i386' }} + BUILD_DEBUG: ${{ contains(matrix.config.checks, 'debug') }} BUILD_DOCS: ${{ contains(matrix.config.checks, 'doc') }} CC: ccache ${{ matrix.config.compiler }} DEF_LIB: ${{ matrix.config.library }} @@ -39,7 +40,7 @@ jobs: mini: mini - os: ubuntu-20.04 compiler: gcc - checks: abi+doc+tests + checks: abi+debug+doc+tests - os: ubuntu-20.04 compiler: clang checks: asan+doc+tests -- 2.39.2