From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36691427E2; Mon, 20 Mar 2023 15:54:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15FA940A7F; Mon, 20 Mar 2023 15:54:31 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2065.outbound.protection.outlook.com [40.107.92.65]) by mails.dpdk.org (Postfix) with ESMTP id 139F7406BC for ; Mon, 20 Mar 2023 15:54:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FiF47gumHT61ZKPHLQACO7YKo/kZ/hd5sUMP+CS7ifIrW3aXldH5JvdUZpiL52FqjT6MWPph6dwbe6rBIQDwO7rp++VknOW5x1ujsgnhTtb2MblkdViVU+0u/hjFw/6YQNTRDs8NWr8L61xY7CiAwdjdCss67fKoqapmGC0nD7MxUaE4GO66nb4neECMHQzHYHXZMxlymYUPMjRyj7aBBM4pDPve+B79exRX41bTVbjkdtDXzQs1nIYfIoUHKTejqsCf39SpjaZeJweagyXPuhE7EPNSLj9FWaCKGrjASD2Cr/YXOiChUC20oxi80mRfwaNrSG9DDREMPOKppXxR9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XmAHIGG5ABb7aF3h9kGc48C9NGzjK6tzwVcUltIHigE=; b=Y5MIr91/iq4p3s1y4Nzodeh+M/YDbpVWdXGYeOQjFxOK60rrXvHtRmqjIz4Q/2MqAN/tR7qbfwt0yYBM2dCt2Zbd2ELvRNBI9ST+ZnnCCA0JpFGjUOh3mn7N5foNgmfXh9RiuMa3pe2NS7WRWbk6ljtGqYewovESarwN/mIeJE8Sdu1tTHS5u18LgEpvqoqIYSgb99duQ7PxrX1iY1xoVsnl9mPZ9NiboBKwEfjBEwBYzq09IdntPae44Cs7Q4zAGXP0olVMQw2q3/EEqACWDkpHxt2ygzFFyv17PesL/e2R7jQkzb5AqH8I258HSNSdzMoGYk9OeNWZjcTYgdtRIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmAHIGG5ABb7aF3h9kGc48C9NGzjK6tzwVcUltIHigE=; b=LbqXpGOHuZHahTa5QFeGiaoQxjDnFm1tyi1lW2lPxfsuL6JVqCHuX72yi7s5J+sSkXSgAgHT+rjfZV+wiLBugAPzSLYGzYppF0Yn9yJxGACSa3Nbos7sDLzF7NzvYSypr86rpcy470yVvQr+RW7Aoci1kyzR6X7mIjRg3ksDYR0m8HRAE1/JIjl4sOY7bBH6IcggSfdaG5O7qZaasn5F5hBa4r1VBOThAj8ewaXjA3OUizeJdapC8s+cuT4LDwI1XxFD09/R8S2ADLombC52G5drNZ/YfWrDaMKBOL7sPgcj4M5iIV2XWO1HlKlN08YxtbWWc1kBXCVYGiUZcGxJMg== Received: from MW4PR03CA0066.namprd03.prod.outlook.com (2603:10b6:303:b6::11) by CY8PR12MB7756.namprd12.prod.outlook.com (2603:10b6:930:85::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:54:28 +0000 Received: from CO1NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b6:cafe::d9) by MW4PR03CA0066.outlook.office365.com (2603:10b6:303:b6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:54:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT100.mail.protection.outlook.com (10.13.175.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:54:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 20 Mar 2023 07:54:14 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 20 Mar 2023 07:54:13 -0700 From: Erez Shitrit To: CC: , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 1/4] net/mlx5/hws: fix bug in pattern creation Date: Mon, 20 Mar 2023 16:53:40 +0200 Message-ID: <20230320145343.449023-1-erezsh@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT100:EE_|CY8PR12MB7756:EE_ X-MS-Office365-Filtering-Correlation-Id: 89480434-88a1-40ea-ea7b-08db29530159 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: THWxeJcdT3cE40dqlzm1zGsZxNGHbpzGJMrbCIoMcODc+i2KqS4Piy5atSEsGrZAGh7cvbZNwlogmqX5fhTKXdmW3dzOrGtvFIxlF/o/dIn4MH3IA2dD9DfMs3n+v8O9dnJdZNttBuse6PgXPF5KeZ4DgbYPuH+FG7edq8HOq/JCXBwEU28zSmhAQwcN6ihxnNGZmkXsXvBuwDaW7YfWPKahdH5rw4OVAJX9hJoo7T1v2ALT3fpBGZs+CR3ntWRQwLDShV5LCLfYiGtfyViNgXwNRBfMnbBYQaJ09Bc3zgJASwgiui+x9N+iP+GuHZ/Im1yNglQkjBGoaWCQSe3FV2Fl7QlHf20b0O99cL6HvtYilEJN1zxpv2GMjl/3Zh5fUJeHjHa3sZuODdm/HpwN/zSsjKFKVytWTe17y8lTfMM4odw7EO+ZNbr8vqoloc7pcr3XY5yzYmxLQsfbRnX418UAxWihyZ0jHOjL2yuUhQGJ0zLdminpu5krLAgOG56tvyjEjGZLPFiUnXZS705jtpfU/8r+almn1iFTSSKLyPENavPKy0zxTLXxhh7/rUp0Q4R43HG7qKUgFfxr/3XuqCFk9Arhgx/b8zUI+XnK1TEAjGCtDXoSwNvG2YRhNlePCtk4wYuThrKHbPpBYJ7y8o4927+AkNi1DAQO18pnARsIXOeE/ab0U2ZsYUQkDHdg+B+8SijwIBX5GfLennC7ktquKSKAnb79OAQ2ZSGIy8IPU4lS1V6sAzTlDuHavYvD X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(396003)(346002)(39860400002)(376002)(136003)(451199018)(46966006)(36840700001)(40470700004)(2616005)(7696005)(107886003)(16526019)(186003)(6286002)(426003)(4326008)(47076005)(83380400001)(478600001)(6666004)(336012)(316002)(54906003)(6916009)(70586007)(70206006)(26005)(1076003)(8676002)(36860700001)(41300700001)(8936002)(5660300002)(7636003)(40460700003)(82740400003)(2906002)(356005)(55016003)(86362001)(82310400005)(36756003)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 14:54:28.3032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89480434-88a1-40ea-ea7b-08db29530159 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7756 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When creating a new pattern the data area should be clean, otherwise when the data will come from the arg object it will do OR operation on the data part in the pattern. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") Reviewed-by: Alex Vesker Signed-off-by: Erez Shitrit --- drivers/net/mlx5/hws/mlx5dr_cmd.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index a444fb4438..0adcedd9c9 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -523,9 +523,11 @@ mlx5dr_cmd_header_modify_pattern_create(struct ibv_context *ctx, uint32_t in[MLX5_ST_SZ_DW(create_header_modify_pattern_in)] = {0}; uint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0}; struct mlx5dr_devx_obj *devx_obj; - void *pattern_data; + uint64_t *pattern_data; + int num_of_actions; void *pattern; void *attr; + int i; if (pattern_length > MAX_ACTIONS_DATA_IN_HEADER_MODIFY) { DR_LOG(ERR, "Pattern length %d exceeds limit %d", @@ -551,9 +553,19 @@ mlx5dr_cmd_header_modify_pattern_create(struct ibv_context *ctx, /* Pattern_length is in ddwords */ MLX5_SET(header_modify_pattern_in, pattern, pattern_length, pattern_length / (2 * DW_SIZE)); - pattern_data = MLX5_ADDR_OF(header_modify_pattern_in, pattern, pattern_data); + pattern_data = (uint64_t *)MLX5_ADDR_OF(header_modify_pattern_in, pattern, pattern_data); memcpy(pattern_data, actions, pattern_length); + num_of_actions = pattern_length / MLX5DR_MODIFY_ACTION_SIZE; + for (i = 0; i < num_of_actions; i++) { + int type; + + type = MLX5_GET(set_action_in, &pattern_data[i], action_type); + if (type != MLX5_MODIFICATION_TYPE_COPY) + /* Action typ-copy use all bytes for control */ + MLX5_SET(set_action_in, &pattern_data[i], data, 0); + } + devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!devx_obj->obj) { DR_LOG(ERR, "Failed to create header_modify_pattern"); -- 2.18.2