From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A9C2427E3; Mon, 20 Mar 2023 17:35:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08BBF4282D; Mon, 20 Mar 2023 17:35:17 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2054.outbound.protection.outlook.com [40.107.101.54]) by mails.dpdk.org (Postfix) with ESMTP id B981E427F2 for ; Mon, 20 Mar 2023 17:35:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVE3FvjXydTnFQwSOi1IqYJrWUPp6VFe6o6f/UwJbk2fTkHsiV5F1z+zBhjgkYTVvVlkeDfuyEXQsWV2c+ue7l917uA4l6yTHWxTRr51Ai+iujQ5QSKrAtwVYOghExAAd6MDD7yEGw4SA/5tkGEh9s7nzYaN+OIlx1buvA/YePVeXIJwzPN1OTwepBcoGGQf5fTvKsKs4Ggqi6F/kWeGngyT6YyKBBCpULPQE4IBIkaiGpEqtGsKKPfq9yHf4JOtG0e7qklOjbXYw1zV31dS8M+N5cZahQ7DV2c1AwZhXtJvGwna6XZ0//xNh6HQmio9LAnk6cWWN2QALiHe+yJrSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l2jCM1B6ibpccGCSJdjcTE6xhukWCOoSFVpgujADW10=; b=gn7VnIBsbLORG+N2gZzFRadRS4TLGzCtfiSvkdbe/FRX2h3fHWny4FRdtc3oKnDjnvvDI/7UkA1gvL2sJmsbOwPbLx3XKtISY+M28h7QiVGqqnlovZj+wr0zMPAW2cbJZU8kdOgu1rWJEdfKDy3wwR9Ju48d2m8QCg3qX0OAljGmyMkWlz6XmHUlrKHk9fx7fNsxPrGZlP2v5QlAFCYWfmW2aQernkwFUEaYIyMDn+7lvZ8msO5DU59yslfbslAvHrx8VApkwD5ptRqfim6x0wye93CnQ0ZhVqOGni4Zt6A2IvomBdv5XZVp2b+dj9VRpTSuF3dPWpr6nua7wSF/IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l2jCM1B6ibpccGCSJdjcTE6xhukWCOoSFVpgujADW10=; b=QZMxhikDh0y6ztO5yH9eP6tdHzy2poiFFUak3Ju20X6XZTYeqy1J52obtrjbTPaKGpxY0bPsuLL0lT+C/NzDrGH3kuHNXxvs9Ins1HCG2fjRm7RRoKx0hA5ZFIZxoB9zpbA0xL12EiOakgF9Nb/tgzwF/sirI3FiRegZqIdqq5osog+Uu2cr3aVo5dcBqDcO07vODxaubTH4UZjva88phZ8rkuPsxApqWIQurownsAr6kuu1NQJBEerKXKsa+PhI7UkV4uUq1eNHR559/aMgBG0ywZ2MtuLTL86ibUmMKU1H5bu0LgZnF8ODr1s3lo771JlsAzealh5j8tJd6bYq3A== Received: from MW4PR03CA0076.namprd03.prod.outlook.com (2603:10b6:303:b6::21) by BL1PR12MB5756.namprd12.prod.outlook.com (2603:10b6:208:393::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 16:35:13 +0000 Received: from CO1NAM11FT053.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b6:cafe::82) by MW4PR03CA0076.outlook.office365.com (2603:10b6:303:b6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 16:35:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT053.mail.protection.outlook.com (10.13.175.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.16 via Frontend Transport; Mon, 20 Mar 2023 16:35:13 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 20 Mar 2023 09:35:01 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 20 Mar 2023 09:34:59 -0700 From: Erez Shitrit To: CC: , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH] net/mlx5/hws: shared context uses defaults from local context Date: Mon, 20 Mar 2023 18:34:41 +0200 Message-ID: <20230320163443.454222-2-erezsh@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20230320163443.454222-1-erezsh@nvidia.com> References: <20230320163443.454222-1-erezsh@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT053:EE_|BL1PR12MB5756:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d89f749-c7f3-4378-7656-08db29611499 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uq8V2CtuOL228r60IDIaNrB7RfE2Kk5XU63Xvza2kxqqgtNRq8IuXeKjCb80NjCWgIF2krVo7x/Ud2iyw7MPUTgDgUACUqnPgc5vvfbmOgBtl7nRyiWg2d0PT6z4QLVm1ffeu9yJrIeDeJCFfhSx/v30OJGbMcqe5bgiW8MVJ/al2w8Qk4WG7qlxNXb5DIKdPC8vXzdrZF02pCjAx8OJu47nHUr7awlNL6upfF3Twu+8EEcYXUmf06sbUfJ/teYvHCj0cgKCJ7p4WFuKRC0T/4aDHy+eGu9OZhHGhebzppwVlGBwNf/4zXKvC4y9C/ws8L0kSwS3KvldIQgtzKzMxvfJj6rAIo+2O0Z0q1j6HEi+CI5NR/74ShaA6YJuNajuEdah1htazNRoRPJsI1AEPp4bqkMs90cxcit6NBHjLJgzcw1dtFXulJnCGRl9JjObbnMYHp3GQo833HcejgGcnuxoIxt6ttZefuhk8J1b71FaGkWH1SPOpKnYy4WqI5LFbG98E4j5euHwY0ApMNVG+0KuhVe9PjzidpbVyxkHqkXBr+PlzFAQHK4BVqheCj8Rin1+evYg9YGshCWFFxUPrmbFvCr9HYkNOgvB8mruBesJ9e3lSXaDd/tmSsB5ISyuokQZGzmo2/LJvY2rbxwyR+a0Ax4Ds7uhASCXj7aR9deDAOm2MSjXRzCF7LKaG/8Fn3mtGoQOm4AdHWVbnin1GZ1vAMicOfRXDWphs2WIVk7fDLJGOEh6AK/Dt+duT/EZ X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199018)(40470700004)(36840700001)(46966006)(36860700001)(86362001)(36756003)(7636003)(356005)(82740400003)(6916009)(4326008)(5660300002)(2906002)(8936002)(70206006)(70586007)(1076003)(82310400005)(41300700001)(336012)(2616005)(40460700003)(426003)(186003)(16526019)(6286002)(83380400001)(47076005)(316002)(478600001)(55016003)(40480700001)(54906003)(6666004)(26005)(107886003)(7696005)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 16:35:13.5662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d89f749-c7f3-4378-7656-08db29611499 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT053.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5756 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix default miss behavior for shared resources, the problem could happen in two cases: When the table created, the default miss should go to the alias ft that will direct it back to local context. When the rule is without specific hit address and we are in a shared RTC from here it should be redirected back to the local context. Fixes: ce946c7d3999 ("net/mlx5/hws: support ibv context shared with local one") Reviewed-by: Alex Vesker Signed-off-by: Erez Shitrit --- drivers/net/mlx5/hws/mlx5dr_action.c | 9 ++++++++- drivers/net/mlx5/hws/mlx5dr_table.c | 29 ++++++++++++++++++++++------ 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index 2db62635c1..77cf1f5132 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -1751,8 +1751,15 @@ int mlx5dr_action_get_default_stc(struct mlx5dr_context *ctx, goto free_nop_dw6; } - stc_attr.action_type = MLX5_IFC_STC_ACTION_TYPE_ALLOW; stc_attr.action_offset = MLX5DR_ACTION_OFFSET_HIT; + if (!mlx5dr_context_shared_gvmi_used(ctx)) { + stc_attr.action_type = MLX5_IFC_STC_ACTION_TYPE_ALLOW; + } else { + /* On shared gvmi the default hit behavior is jump to alias end ft */ + stc_attr.action_type = MLX5_IFC_STC_ACTION_TYPE_JUMP_TO_FT; + stc_attr.dest_table_id = ctx->gvmi_res[tbl_type].aliased_end_ft->id; + } + ret = mlx5dr_action_alloc_single_stc(ctx, &stc_attr, tbl_type, &default_stc->default_hit); if (ret) { diff --git a/drivers/net/mlx5/hws/mlx5dr_table.c b/drivers/net/mlx5/hws/mlx5dr_table.c index 327e2ec710..0e5e9b49ab 100644 --- a/drivers/net/mlx5/hws/mlx5dr_table.c +++ b/drivers/net/mlx5/hws/mlx5dr_table.c @@ -272,6 +272,9 @@ static void mlx5dr_table_uninit_shared_ctx_res(struct mlx5dr_table *tbl) /* called under spin_lock ctx->ctrl_lock */ static int mlx5dr_table_init_shared_ctx_res(struct mlx5dr_context *ctx, struct mlx5dr_table *tbl) { + struct mlx5dr_cmd_ft_modify_attr ft_attr = {0}; + int ret; + if (!mlx5dr_context_shared_gvmi_used(ctx)) return 0; @@ -288,8 +291,22 @@ static int mlx5dr_table_init_shared_ctx_res(struct mlx5dr_context *ctx, struct m goto clean_local_ft; } + /* On shared gvmi the default behavior is jump to alias end ft */ + mlx5dr_cmd_set_attr_connect_miss_tbl(tbl->ctx, + tbl->fw_ft_type, + tbl->type, + &ft_attr); + + ret = mlx5dr_cmd_flow_table_modify(tbl->ft, &ft_attr); + if (ret) { + DR_LOG(ERR, "Failed to point table to its default miss"); + goto clean_shared_res; + } + return 0; +clean_shared_res: + mlx5dr_table_put_shared_gvmi_res(tbl); clean_local_ft: mlx5dr_table_destroy_default_ft(tbl, tbl->local_ft); return rte_errno; @@ -337,20 +354,20 @@ static int mlx5dr_table_init(struct mlx5dr_table *tbl) return rte_errno; } - ret = mlx5dr_action_get_default_stc(ctx, tbl->type); + ret = mlx5dr_table_init_shared_ctx_res(ctx, tbl); if (ret) goto tbl_destroy; - ret = mlx5dr_table_init_shared_ctx_res(ctx, tbl); + ret = mlx5dr_action_get_default_stc(ctx, tbl->type); if (ret) - goto put_stc; + goto free_shared_ctx; pthread_spin_unlock(&ctx->ctrl_lock); return 0; -put_stc: - mlx5dr_action_put_default_stc(ctx, tbl->type); +free_shared_ctx: + mlx5dr_table_uninit_shared_ctx_res(tbl); tbl_destroy: mlx5dr_table_destroy_default_ft(tbl, tbl->ft); pthread_spin_unlock(&ctx->ctrl_lock); @@ -363,8 +380,8 @@ static void mlx5dr_table_uninit(struct mlx5dr_table *tbl) return; pthread_spin_lock(&tbl->ctx->ctrl_lock); mlx5dr_action_put_default_stc(tbl->ctx, tbl->type); - mlx5dr_table_destroy_default_ft(tbl, tbl->ft); mlx5dr_table_uninit_shared_ctx_res(tbl); + mlx5dr_table_destroy_default_ft(tbl, tbl->ft); pthread_spin_unlock(&tbl->ctx->ctrl_lock); } -- 2.18.2