From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 164C542803; Wed, 22 Mar 2023 11:17:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C8CD42C4D; Wed, 22 Mar 2023 11:17:00 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by mails.dpdk.org (Postfix) with ESMTP id 13460410DD; Wed, 22 Mar 2023 11:16:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WEZIoI8htmePrMKlDaL5eQga/MVHH6JX1T095tApX2Am0giTH7YL6ys8kKOR8nwMDHBkNEbYPPmapKCi+EnFik4eSzm+bGsvCVL+nQtSr77ybGydGh2bZByeu8eQagqmUtEbSZYJx8C3/fBLqUY5FDm4H8iWxhllvHPm/bzPsxG2M4FD307sYOBbTJ8CQftZTnQQsonO7SU+JgrkTBBhg6ETv2f/y91rXVRuzXkz0p08KnNLmhVWXpkJBMTTIOQ0H/FPPDPaeHcUdelYahiBIGTwhQ1Z4LSpXbTmhN9WUDx94049mtaEsb7TcKE95RhqLSxn7HYeeyHqpXo5Lgz1Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TIYjJ5M3jbXFveNdcX95lcBEY2HGJmXwsQGEZOm8DF4=; b=AnE0cziHui62GvEPwmolm/7TIduGfuzADMvaW2vc0q7CBNXV/+uP21rsAjLYcHN/pG5PPwgMKHkAY7roUWQzT7C6U2CvfXui+GpPlx9w2ctDyXC04A6cCOwKF9kjTqLIIJ0vF8X8njOoqC4ANvwsgK9NMsSO11obTww51psbzQyem3re6diN1routdzKt3xezZZVvCD7QX3R5vahAlkQdWWTm2e1qqddSlJjsecDvoQD3T2L3nJzDgyFmLu8zm9xEoCBeHYy0YBqNdf6199rRDaVJAS/+joRsLSI8hLQCTXHiZDhWaOU3Fz6O9rZ34pCbGcD5zl2jeoo89jBGslwEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TIYjJ5M3jbXFveNdcX95lcBEY2HGJmXwsQGEZOm8DF4=; b=p5UtzntlaL8DjNKUn5F/bRlAVb1eRGdBTFFPp5JdDrJRge8zESwxc/x4RZTtzF17+xLbhl7CIBQNziFwURdvGzC1fwyzu8bzEN2Pc4xYG6ZFe0XFj1ovM/dboGjThgBKyh10yKew/O01ZKBr8D5ZDOIqMoiJ2qLfQLQdW+hBSkzMWgxn7xJeTjzOquHzKPX9OgThvITj5o3syYUo/aHS4PF091+W8rnkh2jJgalQfWiK+D2418gpHv9x+fvgbDjoyRDWGw5EUbGAcJBkJUpGfavvufyuL7PBNI892pH//8wJ441+378tgPrT1SRjl3BG8mgro+jHWsUGS40OhELjhg== Received: from SJ0PR03CA0041.namprd03.prod.outlook.com (2603:10b6:a03:33e::16) by MN2PR12MB4471.namprd12.prod.outlook.com (2603:10b6:208:26f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 10:16:55 +0000 Received: from CO1PEPF00001A5F.namprd05.prod.outlook.com (2603:10b6:a03:33e:cafe::7f) by SJ0PR03CA0041.outlook.office365.com (2603:10b6:a03:33e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Wed, 22 Mar 2023 10:16:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF00001A5F.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.30 via Frontend Transport; Wed, 22 Mar 2023 10:16:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 22 Mar 2023 03:16:39 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 22 Mar 2023 03:16:37 -0700 From: Erez Shitrit To: CC: , , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH] net/mlx5/hws: fix bug in pattern creation Date: Wed, 22 Mar 2023 12:16:18 +0200 Message-ID: <20230322101621.642765-1-erezsh@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00001A5F:EE_|MN2PR12MB4471:EE_ X-MS-Office365-Filtering-Correlation-Id: 56d1d4e0-da15-4135-d13e-08db2abe9007 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: serpnyFegJLtTZl5Q4G1yEzJhLc2lWpZ/dg5W7vkYY4vcUPSQ77T1SEG/6IqINIOzjZiLGMxHx0eUcrW3In66QgE++GhWqKG1TtzYVIJbJnNwpGI2LE8QAlAEMsNHVF3s5W8zwKLSevhU/X8zpiZihi7N31Cx9pde2erVWiz6MLjckRbabsWMa1t7XCxs9xfk3eJhlV+2viCiid4XIZIeZi8cZB/jPyGi34KPL7QvQOIiIbCP0CdwmCaE6vSRMy7Y8sgTy0lWs7Fu0LTYDN+ba0gM4/H4xntaPMZED4/gdBhKsrAxh/myfKmPr3B0CH/OWZuHMxZfc4I1LwYeuD3AS1gF1JRs2KY03r7WrIdgQ/dAyfZmxrwA//RIown9D9L9ooxHEGvUJt6OTHoKilYaSKyE5/X/pBiK3hzkh0xCCZRjRuurTuB5bu8oDWVuteLolgYvySmBaeEv5QB2SDGYoZdu7JRJdgN9jji4JY8NGFV+W4elQOG/QgBmAGYDDJX2WccjeiD3a31Ow0JMVBnGPsKb4j3dmuUENESu3N+Vbghw5/27AE8BYh3Xjc2mG3pbRPaLm6+/YZ35kFf5/0BlMOn2AZiwnUUDeZcWCRcgZZkx/r/a1n+O3iwX4QldkKuU9KkyPotwZ4JnFn5qNSOjEAH2DpBIyQ+gXXKIgaAfKqH8M4MCE8L6/6u3HVo4RW+7jmc2iA/Ab6xdRDeuTUov9TvvsQw82zIjI5k99TcTqFrPlOCVJwgZq2qZk3KpWjH X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199018)(36840700001)(40470700004)(46966006)(47076005)(2616005)(426003)(83380400001)(82310400005)(6666004)(1076003)(107886003)(16526019)(26005)(5660300002)(478600001)(186003)(6286002)(7696005)(316002)(55016003)(7636003)(40460700003)(356005)(36860700001)(336012)(86362001)(82740400003)(70206006)(36756003)(70586007)(41300700001)(54906003)(40480700001)(8676002)(450100002)(2906002)(6916009)(8936002)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 10:16:55.0547 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56d1d4e0-da15-4135-d13e-08db2abe9007 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A5F.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4471 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When creating a new pattern the data area should be clean, otherwise when the data will come from the arg object it will do OR operation on the data part in the pattern. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") Cc: stable@dpdk.org Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_cmd.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index a444fb4438..0adcedd9c9 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -523,9 +523,11 @@ mlx5dr_cmd_header_modify_pattern_create(struct ibv_context *ctx, uint32_t in[MLX5_ST_SZ_DW(create_header_modify_pattern_in)] = {0}; uint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0}; struct mlx5dr_devx_obj *devx_obj; - void *pattern_data; + uint64_t *pattern_data; + int num_of_actions; void *pattern; void *attr; + int i; if (pattern_length > MAX_ACTIONS_DATA_IN_HEADER_MODIFY) { DR_LOG(ERR, "Pattern length %d exceeds limit %d", @@ -551,9 +553,19 @@ mlx5dr_cmd_header_modify_pattern_create(struct ibv_context *ctx, /* Pattern_length is in ddwords */ MLX5_SET(header_modify_pattern_in, pattern, pattern_length, pattern_length / (2 * DW_SIZE)); - pattern_data = MLX5_ADDR_OF(header_modify_pattern_in, pattern, pattern_data); + pattern_data = (uint64_t *)MLX5_ADDR_OF(header_modify_pattern_in, pattern, pattern_data); memcpy(pattern_data, actions, pattern_length); + num_of_actions = pattern_length / MLX5DR_MODIFY_ACTION_SIZE; + for (i = 0; i < num_of_actions; i++) { + int type; + + type = MLX5_GET(set_action_in, &pattern_data[i], action_type); + if (type != MLX5_MODIFICATION_TYPE_COPY) + /* Action typ-copy use all bytes for control */ + MLX5_SET(set_action_in, &pattern_data[i], data, 0); + } + devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!devx_obj->obj) { DR_LOG(ERR, "Failed to create header_modify_pattern"); -- 2.18.2