DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rory Sexton <rory.sexton@intel.com>
To: honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru
Cc: dev@dpdk.org, Rory Sexton <rory.sexton@intel.com>
Subject: [RFC 0/1] ring: add callback infrastructire to ring library
Date: Thu, 23 Mar 2023 11:37:42 +0000	[thread overview]
Message-ID: <20230323113743.4086730-1-rory.sexton@intel.com> (raw)

This is an RFC proposing the addition of a callback infrastructure to the ring
library, particularly in the ring dequeue functions, but they could also be
added to the enqueue functions if desired.

Callbacks in the ring dequeue functions would be beneficial for a number of
reasons including but not limited to the following:
- would allow users to register specific functions to be called on dequeue of a
  ring avoiding the need to call the function within application code on several
  threads reading from said ring.
- would mirror the callback functionality offered by the ethdev library for
  threads that read exclusively from a ring and process packets based off that,
  thus allowing for the same threads to read from either a NIC i/f or directly
  from a ring without needing a different codepath.

The addition of callbacks wouldn't impact the reading of rings by more than 1
cycle when no callbacks are registered. They could also additionally be compiled
in/out as desired to give more confidence in maintaining performance when
callbacks are not required.

This RFC is to give a feel for what the additional APIs would be and how they
would be integrated within the ring dequeue functions. As such only function
declarations are present. If there is a willingness within the community to add
callback infrastructure to the ring library I will implement further code.

Rory Sexton (1):
  ring: add infrastructure to allow callbacks within the ring library

 lib/ring/rte_ring.h      | 133 ++++++++++++++++++++++++++++++++++++++-
 lib/ring/rte_ring_core.h |   3 +
 2 files changed, 135 insertions(+), 1 deletion(-)

-- 
2.34.1


             reply	other threads:[~2023-03-23 11:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 11:37 Rory Sexton [this message]
2023-03-23 11:37 ` [RFC 1/1] ring: add infrastructure to allow callbacks within the " Rory Sexton
2023-10-31 21:41   ` Stephen Hemminger
2023-03-23 11:55 ` [RFC 0/1] ring: add callback infrastructire to " Morten Brørup
2023-04-05  0:46 ` Honnappa Nagarahalli
2023-04-05 14:44   ` Sexton, Rory
2023-04-05 15:49     ` Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230323113743.4086730-1-rory.sexton@intel.com \
    --to=rory.sexton@intel.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).