From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BFC34291E; Tue, 11 Apr 2023 20:05:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21F5E40DFD; Tue, 11 Apr 2023 20:05:58 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 7C3A840C35 for ; Tue, 11 Apr 2023 20:05:56 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id w11so8651859plp.13 for ; Tue, 11 Apr 2023 11:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1681236355; x=1683828355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XSTyGZZhMLy/ycZrDSunNfpjOW2xvsNA9A0xu0BVcYU=; b=qofy4yjF0XH1O/HMw32JHlu/0FdejIHj8WbYrJ5mnSZJZR3oTeA+8HCmwSpmSsfvcU qLVu0TLu3mjfuEjLNx9QcgxUeRbHuPcwFAVcoQllnJZre2Vx/YWqB7/uSsEHLRbRvLGJ Q1PK8+7mp5bLW01QyIm1yNUEi2/VlxewGijdD+dJFoloxuIZJ2NpC18Qkxn0HIfwDH24 oCvU1DPfxCyC0NpS56hj6KFnwd9smYZ11xYX8GgGi/o3Uz4Vl3u2D2lUpG6DctFSeqyh xvyKe1zWBLH28aCXBWxyE+LLkyuwiSypuUNMQ+bC0TjT4XGW8tPnPtBCixicU1xK5lZK DpWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681236355; x=1683828355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XSTyGZZhMLy/ycZrDSunNfpjOW2xvsNA9A0xu0BVcYU=; b=68jAxlwkI0Djrmk4rC5xDgdP7twANfMFEQBWVdfh4SE/f9qLOU3ZevPVsBhtgj6aSh XQo53feqg1zpsRFDFQvmgfv4wuiDxjRSfUkB2Xh62QlOJfsRxwkzRwh9uCXFe8z/cSG9 322RYGpL2klRk2LsjLob6dzQd7Ctsei0Aw3KenFC7f8bQ65/PlF2ZMlpIXjN5zSOwVQu 8ubdyuA1HNyDXEG8JwkGdvDJrP8Wv8vVqnWNmTERvUQUirAPHrrBeyyFZ4NhfMHWmb4p vuiz8ILATLQzxHo6wRrCbrXESTWwsyAEIq24FHsu71sMX9g23ysF4WxT0XYF0bNTmigR BvqQ== X-Gm-Message-State: AAQBX9cgSmqnFUCrH+hze8J0nt1dBYKxim5HdFv/fEm+Za2qiloOOQX3 dKZwLha0acQdTArNfFWeTYrwkQ== X-Google-Smtp-Source: AKy350aco+00ILIn+/2eSJmRpd8bqPuNUnrjW5l3WlxRmR8Sj2GVTpxYyO0AHyUC8g3R0RXXHtKwgA== X-Received: by 2002:a17:902:a701:b0:1a1:f5dd:2dd5 with SMTP id w1-20020a170902a70100b001a1f5dd2dd5mr3980795plq.13.1681236355505; Tue, 11 Apr 2023 11:05:55 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y5-20020a170902700500b001a1c2ee06e0sm9986881plk.15.2023.04.11.11.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 11:05:55 -0700 (PDT) Date: Tue, 11 Apr 2023 11:05:53 -0700 From: Stephen Hemminger To: Nithin Dabilpuram Cc: Thomas Monjalon , Akhil Goyal , , Subject: Re: [PATCH 1/3] security: introduce out of place support for inline ingress Message-ID: <20230411110553.25f7c038@hermes.local> In-Reply-To: <20230411100410.1174495-1-ndabilpuram@marvell.com> References: <20230309085645.1630826-1-ndabilpuram@marvell.com> <20230411100410.1174495-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 11 Apr 2023 15:34:07 +0530 Nithin Dabilpuram wrote: > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index 4bacf9fcd9..866cd4e8ee 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -275,6 +275,17 @@ struct rte_security_ipsec_sa_options { > */ > uint32_t ip_reassembly_en : 1; > > + /** Enable out of place processing on inline inbound packets. > + * > + * * 1: Enable driver to perform Out-of-place(OOP) processing for this inline > + * inbound SA if supported by driver. PMD need to register mbuf > + * dynamic field using rte_security_oop_dynfield_register() > + * and security session creation would fail if dynfield is not > + * registered successfully. > + * * 0: Disable OOP processing for this session (default). > + */ > + uint32_t ingress_oop : 1; > + > /** Reserved bit fields for future extension > * > * User should ensure reserved_opts is cleared as it may change in > @@ -282,7 +293,7 @@ struct rte_security_ipsec_sa_options { > * > * Note: Reduce number of bits in reserved_opts for every new option. > */ > - uint32_t reserved_opts : 17; > + uint32_t reserved_opts : 16; > }; NAK Let me repeat the reserved bit rant. YAGNI Reserved space is not usable without ABI breakage unless the existing code enforces that reserved space has to be zero. Just saying "User should ensure reserved_opts is cleared" is not enough.