DPDK patches and discussions
 help / color / mirror / Atom feed
From: Randy Schacher <stuart.schacher@broadcom.com>
To: dev@dpdk.org
Cc: Shuanglin Wang <shuanglin.wang@broadcom.com>,
	Kishore Padmanabha <kishore.padmanabha@broadcom.com>,
	Michael Baucom <michael.baucom@broadcom.com>
Subject: [PATCH 11/11] net/bnxt: Avoid submitting hwrm rss request when rss mode disabled
Date: Wed, 19 Apr 2023 20:11:22 +0000	[thread overview]
Message-ID: <20230419201122.338133-12-stuart.schacher@broadcom.com> (raw)
In-Reply-To: <20230419201122.338133-1-stuart.schacher@broadcom.com>

From: Shuanglin Wang <shuanglin.wang@broadcom.com>

On WH+, if rss mode isn't enabled, then there is no rss context.
Submitting HWRM_VNIC_RSS_CFG request to firmware would hit a failure.

The fix is to check the rss context. If no rss context, then don't
submit the hwrm request.

Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Reviewed-by: Michael Baucom <michael.baucom@broadcom.com>
Reviewed-by: Shuanglin Wang <shuanglin.wang@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 24a892bacf..d63bf227a6 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -2405,6 +2405,9 @@ bnxt_hwrm_vnic_rss_cfg_non_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic)
 	struct hwrm_vnic_rss_cfg_output *resp = bp->hwrm_cmd_resp_addr;
 	int rc = 0;
 
+	if (vnic->num_lb_ctxts == 0)
+		return rc;
+
 	HWRM_PREP(&req, HWRM_VNIC_RSS_CFG, BNXT_USE_CHIMP_MB);
 
 	req.hash_type = rte_cpu_to_le_32(vnic->hash_type);
-- 
2.25.1


      parent reply	other threads:[~2023-04-19 20:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 20:11 [PATCH 00/11] sync Truflow support with latest release Randy Schacher
2023-04-19 20:11 ` [PATCH 01/11] net/bnxt: remove deprecated features Randy Schacher
2023-04-19 20:11 ` [PATCH 02/11] net/bnxt: update bnxt hsi structure Randy Schacher
2023-04-19 20:11 ` [PATCH 03/11] net/bnxt: update copyright date and cleanup whitespace Randy Schacher
2023-04-19 20:11 ` [PATCH 04/11] net/bnxt: update Truflow core Randy Schacher
2023-04-19 20:11 ` [PATCH 05/11] net/bnxt: update ULP shared session support Randy Schacher
2023-04-19 20:11 ` [PATCH 06/11] net/bnxt: add support for RSS action and Queue action Randy Schacher
2023-04-19 20:11 ` [PATCH 07/11] net/bnxt: add ulp support for rte meter Randy Schacher
2023-04-19 20:11 ` [PATCH 08/11] net/bnxt: update PTP support on Thor Randy Schacher
2023-04-19 20:11 ` [PATCH 09/11] net/bnxt: fix multi-root card support Randy Schacher
2023-04-19 20:11 ` [PATCH 10/11] net/bnxt: add ulp support for ecpri Randy Schacher
2023-04-19 20:11 ` Randy Schacher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230419201122.338133-12-stuart.schacher@broadcom.com \
    --to=stuart.schacher@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=kishore.padmanabha@broadcom.com \
    --cc=michael.baucom@broadcom.com \
    --cc=shuanglin.wang@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).