From: Stephen Hemminger <stephen@networkplumber.org>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>, beilei.xing@intel.com, dev@dpdk.org
Subject: Re: [PATCH] common/idpf: remove unnecessary compile option
Date: Mon, 24 Apr 2023 10:41:46 -0700 [thread overview]
Message-ID: <20230424104146.3d7eedec@hermes.local> (raw)
In-Reply-To: <20230424172919.GA23909@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Mon, 24 Apr 2023 10:29:19 -0700
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> On Mon, Apr 24, 2023 at 09:23:48AM -0700, Stephen Hemminger wrote:
> > On Mon, 24 Apr 2023 18:47:00 -0400
> > Qi Zhang <qi.z.zhang@intel.com> wrote:
> >
> > > Remove compile option "__KERNEL" which should not be considered in
> > > DPDK. Also only #include <rte_xxx> in idpf_osdep.h.
> > >
> > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> > This will cause some warnings in DPDK build depending on compiler
> > version and flags. You need to leave the fallthrough comment or
> > use one of the other fallthrough annotations.
>
> if there are variations of annotating fallthrough i would not object to
> a macro for it being exposed from rte_common.h
>
> full disclosure it would let me use the equivalent that are provided
> with windows and windows toolchains.
Yes having something like __rte_fallthrough would help.
Wouldn't help code that is trying to always work in kernel, DPDK or other places.
Both Gcc and clang use statement attributes and C++ has [[fallthrough]]
https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html
https://clang.llvm.org/docs/AttributeReference.html#fallthrough
next prev parent reply other threads:[~2023-04-24 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 22:47 Qi Zhang
2023-04-24 16:23 ` Stephen Hemminger
2023-04-24 17:29 ` Tyler Retzlaff
2023-04-24 17:41 ` Stephen Hemminger [this message]
2023-04-26 7:12 ` Zhang, Qi Z
2023-04-26 15:38 ` [PATCH v2] " Qi Zhang
2023-04-27 9:36 ` Xing, Beilei
2023-04-27 9:53 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424104146.3d7eedec@hermes.local \
--to=stephen@networkplumber.org \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).