From: Ivan Malov <ivan.malov@arknetworks.am>
To: dev@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ferruh Yigit <ferruh.yigit@amd.com>,
stable@dpdk.org, Andy Moreton <amoreton@xilinx.com>,
Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
Subject: [PATCH 2/2] net/sfc: invalidate dangling MAE flow action FW resource IDs
Date: Mon, 24 Apr 2023 18:30:46 +0400 [thread overview]
Message-ID: <20230424143046.6487-2-ivan.malov@arknetworks.am> (raw)
In-Reply-To: <20230424143046.6487-1-ivan.malov@arknetworks.am>
When reinserting a flow (on port restart, for instance)
FW resource IDs found in the action set specification
need to be invalidated so that the new (reallocated)
FW resource IDs can be accepted by libefx again.
Fixes: 1bbd1ec2348a ("net/sfc: support action VXLAN encap in MAE backend")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
Tested-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
---
drivers/net/sfc/sfc_mae.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c
index e5e9257998..60b9fdc290 100644
--- a/drivers/net/sfc/sfc_mae.c
+++ b/drivers/net/sfc/sfc_mae.c
@@ -1180,6 +1180,8 @@ sfc_mae_action_set_disable(struct sfc_adapter *sa,
}
if (fw_rsrc->refcnt == 1) {
+ efx_mae_action_set_clear_fw_rsrc_ids(action_set->spec);
+
rc = efx_mae_action_set_free(sa->nic, &fw_rsrc->aset_id);
if (rc == 0) {
sfc_dbg(sa, "disabled action_set=%p with AS_ID=0x%08x",
--
2.17.1
next prev parent reply other threads:[~2023-04-24 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 14:30 [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action " Ivan Malov
2023-04-24 14:30 ` Ivan Malov [this message]
2023-05-18 16:25 ` Ferruh Yigit
2023-05-18 17:21 ` Ivan Malov
2023-05-19 8:47 ` Ferruh Yigit
2023-05-19 9:01 ` Ivan Malov
2023-05-22 10:21 ` Ferruh Yigit
2023-05-21 8:36 ` [PATCH v2] drivers: invalidate dangling MAE flow action FW " Ivan Malov
2023-05-22 6:48 ` Andrew Rybchenko
2023-05-22 10:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424143046.6487-2-ivan.malov@arknetworks.am \
--to=ivan.malov@arknetworks.am \
--cc=amoreton@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=denis.pryazhennikov@arknetworks.am \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).