From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 28917429DF;
	Mon, 24 Apr 2023 19:29:23 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AC7BB410ED;
	Mon, 24 Apr 2023 19:29:22 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 9A63D4013F
 for <dev@dpdk.org>; Mon, 24 Apr 2023 19:29:20 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id DA82E21C2A1F; Mon, 24 Apr 2023 10:29:19 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DA82E21C2A1F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1682357359;
 bh=qy3w4+2Aab46s1ZxHf/DPcuQNLjPYLe5p3ORTcyMknI=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Y9//uCUZWtIaMNoHvZk2NfafIUDyDAm5G2++4RBChy+H2HXdsHVUjfiW57qpjMkt+
 +Z/smp57CmYU2OjyrFwLXWuSr9FPQIehdPMb69oKrfPXx4ynNJfnrsSEJt3Ysarbcg
 vL1I9har7vWR/Ybfvbe+cidrv9tDiWtE4MFgQHVM=
Date: Mon, 24 Apr 2023 10:29:19 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Qi Zhang <qi.z.zhang@intel.com>, beilei.xing@intel.com, dev@dpdk.org
Subject: Re: [PATCH] common/idpf: remove unnecessary compile option
Message-ID: <20230424172919.GA23909@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230424224700.997910-1-qi.z.zhang@intel.com>
 <20230424092348.726583b1@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230424092348.726583b1@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Apr 24, 2023 at 09:23:48AM -0700, Stephen Hemminger wrote:
> On Mon, 24 Apr 2023 18:47:00 -0400
> Qi Zhang <qi.z.zhang@intel.com> wrote:
> 
> > Remove compile option "__KERNEL" which should not be considered in
> > DPDK. Also only #include <rte_xxx> in idpf_osdep.h.
> > 
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> This will cause some warnings in DPDK build depending on compiler
> version and flags.  You need to leave the fallthrough comment or
> use one of the other fallthrough annotations.

if there are variations of annotating fallthrough i would not object to
a macro for it being exposed from rte_common.h

full disclosure it would let me use the equivalent that are provided
with windows and windows toolchains.