DPDK patches and discussions
 help / color / mirror / Atom feed
From: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
To: dev@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>,
	Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
	Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified
Date: Fri, 28 Apr 2023 14:27:27 +0400	[thread overview]
Message-ID: <20230428102728.51956-3-denis.pryazhennikov@arknetworks.am> (raw)
In-Reply-To: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am>

The behaviour is undefined in the rte_eth_fec_set() function
when the fec_capa parameter is equal to zero.
Add a check to handle this case.

Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
Acked-by: Ivan Malov <ivan.malov@arknetworks.am>
Acked-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>
---
 lib/ethdev/rte_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 4d0325568322..d02ee161cf6d 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -4751,6 +4751,11 @@ rte_eth_fec_set(uint16_t port_id, uint32_t fec_capa)
 	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 	dev = &rte_eth_devices[port_id];
 
+	if (fec_capa == 0) {
+		RTE_ETHDEV_LOG(ERR, "At least one FEC mode should be specified\n");
+		return -EINVAL;
+	}
+
 	if (*dev->dev_ops->fec_set == NULL)
 		return -ENOTSUP;
 	ret = eth_err(port_id, (*dev->dev_ops->fec_set)(dev, fec_capa));
-- 
2.37.0 (Apple Git-136)


  parent reply	other threads:[~2023-04-28 10:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 10:27 [RFC PATCH 0/3] improve FEC API usage Denis Pryazhennikov
2023-04-28 10:27 ` [RFC PATCH 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-02 14:57   ` Ferruh Yigit
2023-04-28 10:27 ` Denis Pryazhennikov [this message]
2023-05-02 14:57   ` [RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Denis Pryazhennikov
2023-05-02 15:02   ` Ferruh Yigit
2023-05-04  7:13     ` Denis Pryazhennikov
2023-05-04  7:47       ` Ferruh Yigit
2023-05-08 11:47 ` [RFC PATCH v2 0/3] improve FEC API usage Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 3/3] ethdev: update documentation for API to get FEC Denis Pryazhennikov
2023-05-12 11:57   ` [RFC PATCH v2 0/3] improve FEC API usage Ferruh Yigit
2023-06-07 18:41     ` Ferruh Yigit
2023-06-19 12:36     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428102728.51956-3-denis.pryazhennikov@arknetworks.am \
    --to=denis.pryazhennikov@arknetworks.am \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=ivan.malov@arknetworks.am \
    --cc=thomas@monjalon.net \
    --cc=viacheslav.galaktionov@arknetworks.am \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).