From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55FEA42A13; Fri, 28 Apr 2023 12:27:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26AD542F94; Fri, 28 Apr 2023 12:27:37 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 9FEB542DAE for ; Fri, 28 Apr 2023 12:27:33 +0200 (CEST) Received: from localhost.localdomain (unknown [37.252.90.108]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA512) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id 6D7CEE1193; Fri, 28 Apr 2023 14:27:32 +0400 (+04) From: Denis Pryazhennikov To: dev@dpdk.org Cc: Ivan Malov , Viacheslav Galaktionov , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Subject: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Date: Fri, 28 Apr 2023 14:27:28 +0400 Message-Id: <20230428102728.51956-4-denis.pryazhennikov@arknetworks.am> X-Mailer: git-send-email 2.37.0 (Apple Git-136) In-Reply-To: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> References: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Only one valid FEC mode can be get by rte_eth_fec_get(). The previous name implied that more than one FEC mode can be obtained. Documentation was updated accordingly. Signed-off-by: Denis Pryazhennikov Acked-by: Ivan Malov Acked-by: Viacheslav Galaktionov --- lib/ethdev/rte_ethdev.c | 8 ++++---- lib/ethdev/rte_ethdev.h | 9 +++------ 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index d02ee161cf6d..b046d4ea2f06 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -4718,7 +4718,7 @@ rte_eth_fec_get_capability(uint16_t port_id, } int -rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa) +rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode) { struct rte_eth_dev *dev; int ret; @@ -4726,7 +4726,7 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); dev = &rte_eth_devices[port_id]; - if (fec_capa == NULL) { + if (fec_mode == NULL) { RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u current FEC mode to NULL\n", port_id); @@ -4735,9 +4735,9 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa) if (*dev->dev_ops->fec_get == NULL) return -ENOTSUP; - ret = eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_capa)); + ret = eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_mode)); - rte_eth_trace_fec_get(port_id, fec_capa, ret); + rte_eth_trace_fec_get(port_id, fec_mode, ret); return ret; } diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 0f10ac944061..aa71dbafc01f 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -4203,11 +4203,8 @@ int rte_eth_fec_get_capability(uint16_t port_id, * * @param port_id * The port identifier of the Ethernet device. - * @param fec_capa - * A bitmask of enabled FEC modes. If AUTO bit is set, other - * bits specify FEC modes which may be negotiated. If AUTO - * bit is clear, specify FEC modes to be used (only one valid - * mode per speed may be set). + * @param fec_mode + * The current FEC mode. * @return * - (0) if successful. * - (-ENOTSUP) if underlying hardware OR driver doesn't support. @@ -4216,7 +4213,7 @@ int rte_eth_fec_get_capability(uint16_t port_id, * - (-ENODEV) if *port_id* invalid. */ __rte_experimental -int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa); +int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode); /** * @warning -- 2.37.0 (Apple Git-136)