From: <jerinj@marvell.com>
To: <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <david.marchand@redhat.com>,
<ferruh.yigit@xilinx.com>, <stephen@networkplumber.org>,
Jerin Jacob <jerinj@marvell.com>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH v1] examples/ntb: fix build issue with GCC 13
Date: Tue, 2 May 2023 19:19:23 +0530 [thread overview]
Message-ID: <20230502134923.3536075-2-jerinj@marvell.com> (raw)
In-Reply-To: <20230502134923.3536075-1-jerinj@marvell.com>
From: Jerin Jacob <jerinj@marvell.com>
Fix the following build issue by not allowing nb_ids to be zero.
nb_ids can be zero based on rte_rawdev_xstats_get() API
documentation but it is not valid for the case when second
argument is NULL.
examples/ntb/ntb_fwd.c: In function 'ntb_stats_display':
examples/ntb/ntb_fwd.c:945:23: error: 'rte_rawdev_xstats_get'
accessing 8 bytes in a region of size 0 [-Werror=stringop-overflow=]
945 | if (nb_ids != rte_rawdev_xstats_get(dev_id, ids, values, nb_ids)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
examples/ntb/ntb_fwd.c:945:23: note: referencing argument 3
of type 'uint64_t[0]' {aka 'long unsigned int[]'}
In file included from ../examples/ntb/ntb_fwd.c:17:
lib/rawdev/rte_rawdev.h:504:1: note: in a call to function
'rte_rawdev_xstats_get'
504 | rte_rawdev_xstats_get(uint16_t dev_id,
Fixes: 5194299d6ef5 ("examples/ntb: support more functions")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
examples/ntb/ntb_fwd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c
index f9abed28e4..5489c3b3cd 100644
--- a/examples/ntb/ntb_fwd.c
+++ b/examples/ntb/ntb_fwd.c
@@ -923,7 +923,7 @@ ntb_stats_display(void)
/* Get NTB dev stats and stats names */
nb_ids = rte_rawdev_xstats_names_get(dev_id, NULL, 0);
- if (nb_ids < 0) {
+ if (nb_ids <= 0) {
printf("Error: Cannot get count of xstats\n");
return;
}
--
2.40.1
next prev parent reply other threads:[~2023-05-02 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 13:49 [dpdk-dev] [PATCH v1] examples/ip_pipeline: " jerinj
2023-05-02 13:49 ` jerinj [this message]
2023-05-03 8:30 ` Ali Alnubani
2023-05-03 8:33 ` Ali Alnubani
2023-05-02 13:50 jerinj
2023-05-02 13:50 ` [dpdk-dev] [PATCH v1] examples/ntb: " jerinj
2023-05-03 8:37 ` Ali Alnubani
2023-05-04 8:36 ` Guo, Junfeng
2023-05-04 8:46 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502134923.3536075-2-jerinj@marvell.com \
--to=jerinj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).