From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76DDA42A97; Mon, 8 May 2023 17:14:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04087410ED; Mon, 8 May 2023 17:14:12 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id A6EE340685; Mon, 8 May 2023 17:14:10 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id DF69620EAB57; Mon, 8 May 2023 08:14:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DF69620EAB57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1683558849; bh=Owklj1x+cLOlOe5ksg21cH14l5g3nQh8AYkyutBvRy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RaxJT86LjZ5BZD5EnecdSxAPFXspdJvhLoAFEj/QQIGkY3M1vAYi4Zyl4ky0WeDFU J2LGgGmalHjxUa2rF9+K4QwLCp5tm51xF2RIRsIKIVPPsRHd4j6mPqFDjl0kqC4FXS askYRWo2yDb9d0mQiIiUpBm0lxonYi4DfMEsJVjg= Date: Mon, 8 May 2023 08:14:09 -0700 From: Tyler Retzlaff To: Kaiwen Deng Cc: dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Qi Zhang , Ting Xu Subject: Re: [PATCH] net/ice: fix dcf init rss blocked Message-ID: <20230508151409.GA22197@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230506064822.4153301-1-kaiwenx.deng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230506064822.4153301-1-kaiwenx.deng@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, May 06, 2023 at 02:48:22PM +0800, Kaiwen Deng wrote: > The i variable type is uint8_t which causes a dead loop, > changing it to uint32_t will solve this issue. > > Fixes: 3220d865382c ("net/ice: init RSS during DCF start") > Cc: stable@dpdk.org > > Signed-off-by: Kaiwen Deng > --- > drivers/net/ice/ice_dcf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c > index 1c3d22ae0f..2cf5de0380 100644 > --- a/drivers/net/ice/ice_dcf.c > +++ b/drivers/net/ice/ice_dcf.c > @@ -854,7 +854,8 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw) > { > struct rte_eth_dev *dev = hw->eth_dev; > struct rte_eth_rss_conf *rss_conf; > - uint8_t i, j, nb_q; > + uint8_t j, nb_q; > + uint32_t i; should be size_t > int ret; > > rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf; with or without suggested change, also isn't there a warning on gcc or clang that can be enabled to detect this? Acked-by: Tyler Retzlaff