[PATCH] net/ice: fix dcf init rss blocked

[PATCH] net/ice: fix dcf init rss blocked

[Kaiwen Deng]

The i variable type is uint8_t which causes a dead loop,
changing it to uint32_t will solve this issue.

Fixes: 3220d865382c ("net/ice: init RSS during DCF start")
Cc: stable@dpdk.org

Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
 drivers/net/ice/ice_dcf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 1c3d22ae0f..2cf5de0380 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -854,7 +854,8 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw)
 {
 	struct rte_eth_dev *dev = hw->eth_dev;
 	struct rte_eth_rss_conf *rss_conf;
-	uint8_t i, j, nb_q;
+	uint8_t j, nb_q;
+	uint32_t i;
 	int ret;
 
 	rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
-- 
2.34.1

Re: [PATCH] net/ice: fix dcf init rss blocked

[Tyler Retzlaff]

On Sat, May 06, 2023 at 02:48:22PM +0800, Kaiwen Deng wrote:
> The i variable type is uint8_t which causes a dead loop,
> changing it to uint32_t will solve this issue.
> 
> Fixes: 3220d865382c ("net/ice: init RSS during DCF start")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
>  drivers/net/ice/ice_dcf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
> index 1c3d22ae0f..2cf5de0380 100644
> --- a/drivers/net/ice/ice_dcf.c
> +++ b/drivers/net/ice/ice_dcf.c
> @@ -854,7 +854,8 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw)
>  {
>  	struct rte_eth_dev *dev = hw->eth_dev;
>  	struct rte_eth_rss_conf *rss_conf;
> -	uint8_t i, j, nb_q;
> +	uint8_t j, nb_q;
> +	uint32_t i;

should be size_t

>  	int ret;
>  
>  	rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;

with or without suggested change, also isn't there a warning on gcc or
clang that can be enabled to detect this?

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

[PATCH v2] net/ice: fix dcf init rss blocked

[Kaiwen Deng]

The i variable type is uint8_t which causes a dead loop,
changing it to size_t will solve this issue.

Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
 drivers/net/ice/ice_dcf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 1c3d22ae0f..3e3004f51b 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -854,7 +854,8 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw)
 {
 	struct rte_eth_dev *dev = hw->eth_dev;
 	struct rte_eth_rss_conf *rss_conf;
-	uint8_t i, j, nb_q;
+	uint8_t j, nb_q;
+	size_t i;
 	int ret;
 
 	rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
-- 
2.34.1

RE: [PATCH v2] net/ice: fix dcf init rss blocked

[Zhang, Qi Z]

> -----Original Message-----
> From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Sent: Tuesday, May 9, 2023 9:22 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Deng, KaiwenX <kaiwenx.deng@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v2] net/ice: fix dcf init rss blocked
> 
> The i variable type is uint8_t which causes a dead loop, changing it to size_t
> will solve this issue.

Fixes: 3220d865382c ("net/ice: init RSS during DCF start")
Cc: stable@dpdk.org

> 
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

RE: [PATCH v2] net/ice: fix dcf init rss blocked

[Liao, TingtingX]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

> -----Original Message-----

> From: Kaiwen Deng <kaiwenx.deng@intel.com<mailto:kaiwenx.deng@intel.com>>

> Sent: Tuesday, May 9, 2023 9:22 AM

> To: dev@dpdk.org<mailto:dev@dpdk.org>

> Cc: stable@dpdk.org<mailto:stable@dpdk.org>; Yang, Qiming <qiming.yang@intel.com<mailto:qiming.yang@intel.com>>; Zhou, YidingX <yidingx.zhou@intel.com<mailto:yidingx.zhou@intel.com>>; Deng, KaiwenX <kaiwenx.deng@intel.com<mailto:kaiwenx.deng@intel.com>>; Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>

> Subject: [PATCH v2] net/ice: fix dcf init rss blocked

>

> The i variable type is uint8_t which causes a dead loop, changing it to size_t will solve this issue.

>

> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com<mailto:kaiwenx.deng@intel.com>>


Tested-by: Tingting Liao <tingtingx.liao@intel.com<mailto:tingtingx.liao@intel.com>>

[-- Attachment #2: Type: text/html, Size: 4579 bytes --]