From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id DBF4242AA0;
Tue, 9 May 2023 08:04:23 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2003A42D3C;
Tue, 9 May 2023 08:04:07 +0200 (CEST)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by mails.dpdk.org (Postfix) with ESMTP id EF6D542D30
for <dev@dpdk.org>; Tue, 9 May 2023 08:04:05 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1683612246; x=1715148246;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=KeDv2YiEgfdAtW/ynDnajjHKdHuWTSKwXsOZMTXODNw=;
b=Pj/ZPC/bYWvxS4vWqmYMl2kOG5bn+74i4k40C2mJaGz5OM6Jpx4jihPn
0uaY+8EAQePbXh7nZtcTcP6Z1MFESr8+4ZnPjdG5pQH8R7gZxUrCvEP4J
2B5vum1zZVIpJM3t2KFupCSI/tLFoxFFuNQ6ZfP38/VZqqHQkFNVEAw6K
pKdGxMBrpLPExy+y2x9oVxY/qXIJBA2Ym8kmq1GpKPOigadJeCXiZaNLD
XzkF3Y/65BIKeeAGw3YYae9j55mgCf69N3CA2mqGG60Hx6rm6ELmaDe/6
zwu4Wy4nY6P0ZQG/7niIZ7PIIIS69Kr8J4uQ9pSV8fYBk+Xs6aG3/T6OM A==;
X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="351983063"
X-IronPort-AV: E=Sophos;i="5.99,261,1677571200"; d="scan'208";a="351983063"
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 May 2023 23:04:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="701700102"
X-IronPort-AV: E=Sophos;i="5.99,261,1677571200"; d="scan'208";a="701700102"
Received: from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.94])
by fmsmga007.fm.intel.com with ESMTP; 08 May 2023 23:04:03 -0700
From: Zhirun Yan <zhirun.yan@intel.com>
To: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,
ndabilpuram@marvell.com, stephen@networkplumber.org,
pbhagavatula@marvell.com
Cc: cunming.liang@intel.com, haiyue.wang@intel.com,
Zhirun Yan <zhirun.yan@intel.com>
Subject: [PATCH v6 03/15] graph: move node process into inline function
Date: Tue, 9 May 2023 15:03:35 +0900
Message-Id: <20230509060347.1237884-4-zhirun.yan@intel.com>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20230509060347.1237884-1-zhirun.yan@intel.com>
References: <20230331040306.3143693-1-zhirun.yan@intel.com>
<20230509060347.1237884-1-zhirun.yan@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Node process is a single and reusable block, move the code into an inline
function.
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Signed-off-by: Cunming Liang <cunming.liang@intel.com>
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
---
lib/graph/rte_graph_model_rtc.h | 20 ++---------------
lib/graph/rte_graph_worker_common.h | 33 +++++++++++++++++++++++++++++
2 files changed, 35 insertions(+), 18 deletions(-)
diff --git a/lib/graph/rte_graph_model_rtc.h b/lib/graph/rte_graph_model_rtc.h
index 10b359772f..4b6236e301 100644
--- a/lib/graph/rte_graph_model_rtc.h
+++ b/lib/graph/rte_graph_model_rtc.h
@@ -21,9 +21,6 @@ rte_graph_walk_rtc(struct rte_graph *graph)
const rte_node_t mask = graph->cir_mask;
uint32_t head = graph->head;
struct rte_node *node;
- uint64_t start;
- uint16_t rc;
- void **objs;
/*
* Walk on the source node(s) ((cir_start - head) -> cir_start) and then
@@ -42,21 +39,8 @@ rte_graph_walk_rtc(struct rte_graph *graph)
*/
while (likely(head != graph->tail)) {
node = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);
- RTE_ASSERT(node->fence == RTE_GRAPH_FENCE);
- objs = node->objs;
- rte_prefetch0(objs);
-
- if (rte_graph_has_stats_feature()) {
- start = rte_rdtsc();
- rc = node->process(graph, node, objs, node->idx);
- node->total_cycles += rte_rdtsc() - start;
- node->total_calls++;
- node->total_objs += rc;
- } else {
- node->process(graph, node, objs, node->idx);
- }
- node->idx = 0;
- head = likely((int32_t)head > 0) ? head & mask : head;
+ __rte_node_process(graph, node);
+ head = likely((int32_t)head > 0) ? head & mask : head;
}
graph->tail = 0;
}
diff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h
index b58f8f6947..e25eabc81f 100644
--- a/lib/graph/rte_graph_worker_common.h
+++ b/lib/graph/rte_graph_worker_common.h
@@ -130,6 +130,39 @@ void __rte_node_stream_alloc_size(struct rte_graph *graph,
/* Fast path helper functions */
+/**
+ * @internal
+ *
+ * Enqueue a given node to the tail of the graph reel.
+ *
+ * @param graph
+ * Pointer Graph object.
+ * @param node
+ * Pointer to node object to be enqueued.
+ */
+static __rte_always_inline void
+__rte_node_process(struct rte_graph *graph, struct rte_node *node)
+{
+ uint64_t start;
+ uint16_t rc;
+ void **objs;
+
+ RTE_ASSERT(node->fence == RTE_GRAPH_FENCE);
+ objs = node->objs;
+ rte_prefetch0(objs);
+
+ if (rte_graph_has_stats_feature()) {
+ start = rte_rdtsc_precise();
+ rc = node->process(graph, node, objs, node->idx);
+ node->total_cycles += rte_rdtsc_precise() - start;
+ node->total_calls++;
+ node->total_objs += rc;
+ } else {
+ node->process(graph, node, objs, node->idx);
+ }
+ node->idx = 0;
+}
+
/**
* @internal
*
--
2.37.2