From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: <jerinj@marvell.com>
Cc: "Jerin Jacob" <jerinjacobk@gmail.com>,
hofors@lysator.liu.se, dev@dpdk.org,
"Morten Brørup" <mb@smartsharesystems.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: [PATCH v3] eventdev: avoid non-burst shortcut for variable-size bursts
Date: Thu, 11 May 2023 10:24:15 +0200 [thread overview]
Message-ID: <20230511082415.6720-1-mattias.ronnblom@ericsson.com> (raw)
In-Reply-To: <20230511081641.6693-1-mattias.ronnblom@ericsson.com>
Use non-burst event enqueue and dequeue calls from burst enqueue and
dequeue only when the burst size is compile-time constant (and equal
to one).
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
v3: Actually include the change v2 claimed to contain.
v2: Wrap builtin call in __extension__, to avoid compiler warnings if
application is compiled with -pedantic. (Morten Brørup)
---
lib/eventdev/rte_eventdev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index a90e23ac8b..a471caeb6d 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1944,7 +1944,7 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t port_id,
* Allow zero cost non burst mode routine invocation if application
* requests nb_events as const one
*/
- if (nb_events == 1)
+ if (__extension__(__builtin_constant_p(nb_events)) && nb_events == 1)
return (fp_ops->enqueue)(port, ev);
else
return fn(port, ev, nb_events);
@@ -2200,7 +2200,7 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t port_id, struct rte_event ev[],
* Allow zero cost non burst mode routine invocation if application
* requests nb_events as const one
*/
- if (nb_events == 1)
+ if (__extension__(__builtin_constant_p(nb_events)) && nb_events == 1)
return (fp_ops->dequeue)(port, ev, timeout_ticks);
else
return (fp_ops->dequeue_burst)(port, ev, nb_events,
--
2.34.1
next prev parent reply other threads:[~2023-05-11 8:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 6:43 [PATCH] " Mattias Rönnblom
2023-05-11 7:09 ` Morten Brørup
2023-05-11 8:16 ` [PATCH v2] " Mattias Rönnblom
2023-05-11 8:24 ` Mattias Rönnblom [this message]
2023-05-11 9:01 ` [PATCH v3] " Morten Brørup
2023-05-12 11:59 ` Jerin Jacob
2023-05-12 13:15 ` Mattias Rönnblom
2023-05-12 13:56 ` Morten Brørup
2023-05-12 14:52 ` Mattias Rönnblom
2023-05-15 12:33 ` Jerin Jacob
2023-05-15 12:38 ` Jerin Jacob
2023-05-15 20:52 ` Mattias Rönnblom
2023-05-16 13:08 ` Jerin Jacob
2023-05-17 7:16 ` Mattias Rönnblom
2023-05-17 12:28 ` Jerin Jacob
2023-05-11 8:24 ` [PATCH v2] " Morten Brørup
2023-05-11 8:29 ` [PATCH] " Mattias Rönnblom
2023-05-11 9:06 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511082415.6720-1-mattias.ronnblom@ericsson.com \
--to=mattias.ronnblom@ericsson.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).