From: Stephen Hemminger <stephen@networkplumber.org>
To: Trevor Tao <Trevor.Tao@arm.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] examples/l3fwd: relax the RSS/Offload requirement
Date: Thu, 11 May 2023 08:39:12 -0700 [thread overview]
Message-ID: <20230511083912.439d8e65@hermes.local> (raw)
In-Reply-To: <PAXPR08MB658953FFB8246A1458456F9F97749@PAXPR08MB6589.eurprd08.prod.outlook.com>
On Thu, 11 May 2023 09:33:35 +0000
Trevor Tao <Trevor.Tao@arm.com> wrote:
> + /* relax the rx rss requirement */
> + if (dev_info.max_rx_queues == 1 || !local_port_conf.rx_adv_conf.rss_conf.rss_hf) {
> + printf("warning: modified the rx mq_mode to RTE_ETH_MQ_RX_NONE base on"
> + " device capability\n");
> local_port_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
> + }
There is no point in doing RSS if only a single queue.
Therefore remove the !local_port.conf portion of the expression.
And since this is normal, no printf is needed.
next prev parent reply other threads:[~2023-05-11 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230511080612.126034-1-trevor.tao@arm.com>
2023-05-11 9:33 ` Trevor Tao
2023-05-11 15:39 ` Stephen Hemminger [this message]
2023-05-12 4:34 ` Trevor Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511083912.439d8e65@hermes.local \
--to=stephen@networkplumber.org \
--cc=Trevor.Tao@arm.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).