From: Ciara Power <ciara.power@intel.com>
To: Kai Ji <kai.ji@intel.com>
Cc: dev@dpdk.org, Saoirse O'Donovan <saoirse.odonovan@intel.com>,
stable@dpdk.org, Ciara Power <ciara.power@intel.com>
Subject: [PATCH] crypto/openssl: fix memory free issue
Date: Thu, 11 May 2023 13:59:44 +0000 [thread overview]
Message-ID: <20230511135944.142416-1-ciara.power@intel.com> (raw)
From: Saoirse O'Donovan <saoirse.odonovan@intel.com>
Allocated memory was being freed using 'free' when it should have been
freed using 'OPENSSL_free'. This has now been modified so that the
correct method is used to free allocated memory.
Coverity issue: 384415
Fixes: 4c7ae22f1f83 ("crypto/openssl: update DSA routine with 3.0 EVP API")
Cc: kai.ji@intel.com
Cc: stable@dpdk.org
Signed-off-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index 384d262621..f65fbca300 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1927,7 +1927,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop,
if (EVP_PKEY_sign(dsa_ctx, dsa_sign_data, &outlen, op->message.data,
op->message.length) <= 0) {
- free(dsa_sign_data);
+ OPENSSL_free(dsa_sign_data);
goto err_dsa_sign;
}
@@ -1935,7 +1935,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop,
DSA_SIG *sign = d2i_DSA_SIG(NULL, &dsa_sign_data_p, outlen);
if (!sign) {
OPENSSL_LOG(ERR, "%s:%d\n", __func__, __LINE__);
- free(dsa_sign_data);
+ OPENSSL_free(dsa_sign_data);
goto err_dsa_sign;
} else {
const BIGNUM *r = NULL, *s = NULL;
@@ -1947,7 +1947,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop,
}
DSA_SIG_free(sign);
- free(dsa_sign_data);
+ OPENSSL_free(dsa_sign_data);
return 0;
err_dsa_sign:
--
2.25.1
next reply other threads:[~2023-05-11 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 13:59 Ciara Power [this message]
2023-05-11 14:26 ` Ji, Kai
2023-05-24 12:11 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511135944.142416-1-ciara.power@intel.com \
--to=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
--cc=saoirse.odonovan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).