From: Rongwei Liu <rongweil@nvidia.com>
To: <dev@dpdk.org>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,
<orika@nvidia.com>, <thomas@monjalon.net>
Subject: [PATCH v1] net/mlx5: add test for hot upgrade
Date: Tue, 16 May 2023 08:41:37 +0300 [thread overview]
Message-ID: <20230516054137.1396922-1-rongweil@nvidia.com> (raw)
This patch adds testpmd app a runtime function to test the hot
upgrade API.
testpmd> mlx5 set flow_engine <0|1> (flag)
0 stands for active mode while 1 for standby mode.
Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
doc/guides/nics/mlx5.rst | 10 ++++++
drivers/net/mlx5/mlx5_testpmd.c | 63 +++++++++++++++++++++++++++++++++
2 files changed, 73 insertions(+)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 7a137d5f6a..1867b2a3c0 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -2057,3 +2057,13 @@ where:
* ``sw_queue_id``: queue index in range [64536, 65535].
This range is the highest 1000 numbers.
* ``hw_queue_id``: queue index given by HW in queue creation.
+
+Set Flow Engine Mode
+^^^^^^^^^^^^^^^^^^^^
+
+Set the flow engine to active(0) or standby(1) mode with specific flags::
+ testpmd> mlx5 set flow_engine <0|1> (flags)
+
+This command works for software steering only.
+Default FDB jump should be disabled if switchdev is enabled.
+The mode will propagate to all the probed ports.
diff --git a/drivers/net/mlx5/mlx5_testpmd.c b/drivers/net/mlx5/mlx5_testpmd.c
index 879ea2826e..cb0cafe1e9 100644
--- a/drivers/net/mlx5/mlx5_testpmd.c
+++ b/drivers/net/mlx5/mlx5_testpmd.c
@@ -561,6 +561,64 @@ cmdline_parse_inst_t mlx5_cmd_unmap_ext_rxq = {
}
};
+/* Set flow engine mode with flags command. */
+struct mlx5_cmd_set_flow_engine_mode {
+ cmdline_fixed_string_t mlx5;
+ cmdline_fixed_string_t set;
+ cmdline_fixed_string_t flow_engine;
+ uint8_t mode;
+ uint32_t flags;
+};
+
+
+static void
+mlx5_cmd_set_flow_engine_mode_parsed(void *parsed_result,
+ __rte_unused struct cmdline *cl,
+ __rte_unused void *data)
+{
+ struct mlx5_cmd_set_flow_engine_mode *res = parsed_result;
+ int ret;
+
+ ret = rte_pmd_mlx5_flow_engine_set_mode((enum mlx5_flow_engine_mode)res->mode, res->flags);
+
+ if (ret < 0)
+ fprintf(stderr, "Fail to set flow_engine to %s mode with flags %x, error %s\n",
+ !res->mode ? "active" : "standby", res->flags, strerror(-ret));
+ else
+ TESTPMD_LOG(DEBUG, "Set %d ports flow_engine to %s mode with flags %x\n", ret,
+ !res->mode ? "active" : "standby", res->flags);
+}
+
+cmdline_parse_token_string_t mlx5_cmd_set_flow_engine_mode_mlx5 =
+ TOKEN_STRING_INITIALIZER(struct mlx5_cmd_set_flow_engine_mode, mlx5,
+ "mlx5");
+cmdline_parse_token_string_t mlx5_cmd_set_flow_engine_mode_set =
+ TOKEN_STRING_INITIALIZER(struct mlx5_cmd_set_flow_engine_mode, set,
+ "set");
+cmdline_parse_token_string_t mlx5_cmd_set_flow_engine_mode_flow_engine =
+ TOKEN_STRING_INITIALIZER(struct mlx5_cmd_set_flow_engine_mode, flow_engine,
+ "flow_engine");
+cmdline_parse_token_num_t mlx5_cmd_set_flow_engine_mode_mode =
+ TOKEN_NUM_INITIALIZER(struct mlx5_cmd_set_flow_engine_mode, mode,
+ RTE_UINT8);
+cmdline_parse_token_num_t mlx5_cmd_set_flow_engine_mode_flags =
+ TOKEN_NUM_INITIALIZER(struct mlx5_cmd_set_flow_engine_mode, flags,
+ RTE_UINT32);
+
+cmdline_parse_inst_t mlx5_cmd_set_flow_engine_mode = {
+ .f = &mlx5_cmd_set_flow_engine_mode_parsed,
+ .data = NULL,
+ .help_str = "mlx5 set flow_engine <0|1> (flag)",
+ .tokens = {
+ (void *)&mlx5_cmd_set_flow_engine_mode_mlx5,
+ (void *)&mlx5_cmd_set_flow_engine_mode_set,
+ (void *)&mlx5_cmd_set_flow_engine_mode_flow_engine,
+ (void *)&mlx5_cmd_set_flow_engine_mode_mode,
+ (void *)&mlx5_cmd_set_flow_engine_mode_flags,
+ NULL,
+ }
+};
+
static struct testpmd_driver_commands mlx5_driver_cmds = {
.commands = {
{
@@ -588,6 +646,11 @@ static struct testpmd_driver_commands mlx5_driver_cmds = {
.help = "mlx5 port (port_id) ext_rxq unmap (sw_queue_id)\n"
" Unmap external Rx queue ethdev index mapping\n\n",
},
+ {
+ .ctx = &mlx5_cmd_set_flow_engine_mode,
+ .help = "mlx5 set flow_engine (mode) (flag)\n"
+ " Set flow_engine to the specific mode with flags.\n\n"
+ },
{
.ctx = NULL,
},
--
2.27.0
next reply other threads:[~2023-05-16 5:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 5:41 Rongwei Liu [this message]
2023-06-19 12:09 ` Raslan Darawsheh
2023-06-26 20:22 ` Thomas Monjalon
2023-09-18 12:17 ` Rongwei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516054137.1396922-1-rongweil@nvidia.com \
--to=rongweil@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).