From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EC2242B24; Tue, 16 May 2023 17:16:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A67C41153; Tue, 16 May 2023 17:16:16 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 02701410EE for ; Tue, 16 May 2023 17:16:14 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1aad5245571so98499685ad.1 for ; Tue, 16 May 2023 08:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684250173; x=1686842173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2f8XtphqubxjcXDSFm2rDmxEjb18p+Uzi4T4l2qyQ/c=; b=Alt0UW1cxGKf+fWilFBLNOOyTxFGGZBPQVcASGvUjRdesRpzjLRx37DR4ZQtIQw8Ni Y2/4pjKDVbp/suyjmL8Y/bz4htPHarEtLWUyFM7mqDUb6bMNxg38cBdvf8LUvQLbx9fV QZvHO2pNyRvXXa09JYN4LIRYHh9Tx78DE6EUMORHipokcpIf+HR30FL8rfHqj0DZJzv0 uNpSQG9kSPBcdZzgAflXjZCjZvb+1DXnmMVdPnB3T+QKgNBX19VyzTRPs9JqLE4e0Tok FlqXUDpl6apHLDqXZ4eSoSIPQvIQYeMbCfbm7ceHHwg1gRNrKFbfZBKq6UBTKDYK8/t9 t4Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684250173; x=1686842173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2f8XtphqubxjcXDSFm2rDmxEjb18p+Uzi4T4l2qyQ/c=; b=HqYkGgb+qYU7WCjP4okWEetYJY9f/0lQvXJl6c3vpAyaY+peAq311qUFOsZD45t9AY G95K75yo42BMHB+3NhmQ3gDWLFFa1dCvCuPDAwn4l6nmiztDrEOW8snFx8xHIc1rgpeC Dj2OfulSP5Lgwp7lgiKFO2IzuuS5iIH2euPLhVYejLRLl8wpS2pDD92oEoUC0A4XGnXc pFwOOkS5j1e0ysMpSB+h0astEyuNAQjXcRXOP/cU6LmvGzP/XC2rduazIQssvBhmZKmd fmzc/C8eodTmcnJNySyqHfhTV2DSjeU7l5MljdGsTNmZnkL1p8Ng2BnZCDy+TEoWbQNA Y+1A== X-Gm-Message-State: AC+VfDwRwX25Ik01P2EexDGFL4B6DmIesK+hur+F4pce3c2vE/YoaSB+ j9YCHHDuZpNGWn9JrcsEW4+0mA== X-Google-Smtp-Source: ACHHUZ4k0ifmpb+OixpG2Yf8f1FGhQvzeaPO8XaTJ+6gWpX3axIyijXfoR8wXEQvlKcDxS1S50hcOw== X-Received: by 2002:a17:902:a609:b0:1ac:946e:4690 with SMTP id u9-20020a170902a60900b001ac946e4690mr26020974plq.49.1684250173229; Tue, 16 May 2023 08:16:13 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id u4-20020a17090341c400b001ab39cd875csm15588352ple.133.2023.05.16.08.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 08:16:13 -0700 (PDT) Date: Tue, 16 May 2023 08:16:11 -0700 From: Stephen Hemminger To: Yasin CANER Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH v2] lib/kni : coding style is fixed Message-ID: <20230516081611.13644b82@hermes.local> In-Reply-To: <20230516110359.479441-1-yasinncaner@gmail.com> References: <20230516104853.479297-1-yasinncaner@gmail.com> <20230516110359.479441-1-yasinncaner@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 16 May 2023 11:03:59 +0000 Yasin CANER wrote: > + /* First, getting allocation count from alloc_q. alloc_q is allocated in this function*/ > + /* and/or kni_alloc function from mempool.*/ > + /* If alloc_q is completely removed, it shall be allocated again.*/ If you send another version of this patch. It would be good to follow the style of multi-line comment. /* First, getting allocation count from alloc_q. alloc_q is allocated in this function * and/or kni_alloc function from mempool. * If alloc_q is completely removed, it shall be allocated again. */