From: Stephen Hemminger <stephen@networkplumber.org>
To: Abdullah Sevincer <abdullah.sevincer@intel.com>
Cc: dev@dpdk.org, jerinj@marvell.com, reshma.pattan@intel.com
Subject: Re: [PATCH v14] app/procinfo: display eventdev xstats
Date: Wed, 17 May 2023 15:45:44 -0700 [thread overview]
Message-ID: <20230517154544.55c83121@hermes.local> (raw)
In-Reply-To: <20230517223724.2417630-1-abdullah.sevincer@intel.com>
On Wed, 17 May 2023 17:37:24 -0500
Abdullah Sevincer <abdullah.sevincer@intel.com> wrote:
> +static int
> +parse_eventdev_dump_xstats_params(char *list)
> +{
> + uint8_t evdev_id;
> + evdev_id = (uint8_t)atoi(list);
> +
> + if (evdev_id >= RTE_EVENT_MAX_DEVS) {
> + printf("Invalid eventdev id, id should be between 0 - %d\n", RTE_EVENT_MAX_DEVS-1);
> + return -EINVAL;
> + }
The cast will cause truncation of large values, so this might be a nop.
If you really want to check, then something like:
unsigned long evdev_id;
char *endp;
evdev_id = strtoul(list, &endp, 0);
if (!*list || !*endp || evdev_id >= RTE_EVENT_MAX_DEVS) {
fprintf(stderr, "Invalid eventdev id: %s\n", list);
return -EINVAL;
}
next prev parent reply other threads:[~2023-05-17 22:45 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 15:30 [PATCH] app/eventdev_dump: introduce eventdev_dump application Timothy McDaniel
2022-04-10 6:48 ` Jerin Jacob
2022-04-10 13:18 ` McDaniel, Timothy
2023-02-06 18:34 ` [PATCH v2] app/procinfo: display eventdev xstats for PMD data Abdullah Sevincer
2023-02-06 23:05 ` [PATCH v3] " Abdullah Sevincer
2023-02-07 0:22 ` Stephen Hemminger
2023-02-12 19:43 ` Sevincer, Abdullah
2023-02-17 15:58 ` Sevincer, Abdullah
2023-02-17 16:33 ` Stephen Hemminger
2023-02-22 1:54 ` Sevincer, Abdullah
2023-02-07 0:04 ` [PATCH v4] " Abdullah Sevincer
2023-02-07 16:33 ` [PATCH v5] " Abdullah Sevincer
2023-02-23 1:08 ` [PATCH v6] " Abdullah Sevincer
2023-02-27 16:33 ` Jerin Jacob
2023-03-03 10:58 ` Pattan, Reshma
2023-03-03 16:22 ` Sevincer, Abdullah
2023-03-04 7:17 ` Pattan, Reshma
2023-03-09 18:27 ` [PATCH v7] app/procinfo: display eventdev xstats Abdullah Sevincer
2023-03-09 20:31 ` Stephen Hemminger
2023-03-10 17:35 ` Sevincer, Abdullah
2023-03-10 17:49 ` Stephen Hemminger
2023-03-10 18:06 ` Sevincer, Abdullah
2023-03-09 18:51 ` [PATCH v8] " Abdullah Sevincer
2023-03-15 11:56 ` Pattan, Reshma
2023-03-15 19:40 ` Sevincer, Abdullah
2023-03-15 14:24 ` Pattan, Reshma
2023-03-18 18:49 ` Sevincer, Abdullah
2023-03-20 2:11 ` [PATCH v9] " Abdullah Sevincer
2023-03-20 2:15 ` [PATCH v10] " Abdullah Sevincer
2023-03-20 2:19 ` [PATCH v11] " Abdullah Sevincer
2023-03-20 2:23 ` [PATCH v12] " Abdullah Sevincer
2023-03-20 17:29 ` Pattan, Reshma
2023-03-20 18:01 ` Sevincer, Abdullah
2023-03-20 18:35 ` Sevincer, Abdullah
2023-03-21 9:37 ` Pattan, Reshma
2023-03-21 10:20 ` Sevincer, Abdullah
2023-03-21 10:27 ` Pattan, Reshma
2023-05-17 21:22 ` [PATCH v13] " Abdullah Sevincer
2023-05-17 22:37 ` [PATCH v14] " Abdullah Sevincer
2023-05-17 22:45 ` Stephen Hemminger [this message]
2023-05-17 23:30 ` Sevincer, Abdullah
2023-05-24 15:09 ` Pattan, Reshma
2023-05-25 6:08 ` [PATCH v15] " Abdullah Sevincer
2023-05-25 15:24 ` Stephen Hemminger
2023-05-25 16:41 ` [PATCH v16] " Abdullah Sevincer
2023-05-25 17:35 ` Stephen Hemminger
2023-05-25 17:56 ` Sevincer, Abdullah
2023-05-25 18:47 ` [PATCH v17] " Abdullah Sevincer
2023-05-25 20:07 ` Stephen Hemminger
2023-07-07 9:15 ` Thomas Monjalon
2023-07-07 14:55 ` Stephen Hemminger
2023-07-08 15:11 ` Sevincer, Abdullah
2023-07-08 15:26 ` Stephen Hemminger
2023-05-26 8:32 ` Pattan, Reshma
2023-06-08 17:35 ` Sevincer, Abdullah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517154544.55c83121@hermes.local \
--to=stephen@networkplumber.org \
--cc=abdullah.sevincer@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).