From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B0F542AF1; Thu, 18 May 2023 17:33:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7055040E25; Thu, 18 May 2023 17:33:45 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 462D74014F for ; Thu, 18 May 2023 17:33:44 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1ae454844edso16375295ad.1 for ; Thu, 18 May 2023 08:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684424023; x=1687016023; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=s3OPMQHvt7r6bVKFy+AbAJl9P7jot1EF6Qv/tudV3x4=; b=Jh1xS50GJ/Sj158DmualCRpgMS7LHywSSFbHRZbhdzEqueIDPJ8STO07QTn/cAkAtM GjLDKTwFBTUae91pbTxzc33/Re4zkw/mCUsqLB4eK9AdFz9sRhMoW619Ph9Ayvx+uPSV SqaXFkNVefR0rgN5blIMYZ0cYMTai4nEQvHmMso5lCgk/unoJuDVva9q/Ca4i7kaJEvs 4noUNvnfoabNhiTpoy3WkTnXo03ZK3hQm3vMNh9K9+swlPMpYF/CYYbYDRxY7hYG/ikh x22KWF12LBBPC6r50vBQx83M75HF+LPah+2pvdv+F2ALDo88dIFVcWiIG514Jp/5yVsM Njdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684424023; x=1687016023; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s3OPMQHvt7r6bVKFy+AbAJl9P7jot1EF6Qv/tudV3x4=; b=TpFsMY3bNuyiWUcwXXUtGejS4kODI0SObwDmSn22mJ1yAWHAl0gKZU0GMBCZuOqKl+ MTdnoAEiAoRC4k/xkuQEIp8WkatNG6aAMBU7NwU6qHk0BAboUOfeoJdt8ISIf8T1/ljY mF3ue+mSNoizS08QHH9ue/5hH6MMXrPH1IoARex+HgIwy849HP3O3a/w03us4sr8rM9S e3T7XG4zAboX9c7N/t9l74II3Jl0OAh32y+P5QoSLorCMGZHlUo6Qu0GfYiRse2e4g74 rRlMUjauJ+edRC58T9L/AorvwNy41IiTmA2vjzeM0X/KuoTJ1MexORNqSUmGHI3jX5Mz gM7Q== X-Gm-Message-State: AC+VfDzusJlR6OwQTM36AQbItUVN9n3cutmkTkVgCvWHYaFcKMNzWsnW FI5BxPgWiKIYZSrLQ/3GEvzQ4g== X-Google-Smtp-Source: ACHHUZ74OADZtwliNVwrl747H3XAehE1rCRpqTs+ju5jnA7vZZBvBdUWM3FVkI2pYvP+TRrVJlXhIA== X-Received: by 2002:a17:90a:3cc8:b0:250:aaea:4306 with SMTP id k8-20020a17090a3cc800b00250aaea4306mr3033940pjd.21.1684424023312; Thu, 18 May 2023 08:33:43 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j6-20020a17090aeb0600b0024c1f1cdf98sm279649pjz.13.2023.05.18.08.33.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 08:33:43 -0700 (PDT) Date: Thu, 18 May 2023 08:33:40 -0700 From: Stephen Hemminger To: Ankur Dwivedi Cc: Thomas Monjalon , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Subject: Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch Message-ID: <20230518083341.288fcb82@hermes.local> In-Reply-To: References: <20230303155811.2751210-1-adwivedi@marvell.com> <20230307120514.2774917-1-adwivedi@marvell.com> <20230307120514.2774917-2-adwivedi@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 18 May 2023 13:45:29 +0000 Ankur Dwivedi wrote: > >-----Original Message----- > >From: Ankur Dwivedi > >Sent: Tuesday, March 7, 2023 5:35 PM > >To: dev@dpdk.org > >Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran ; > >Ankur Dwivedi > >Subject: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch > > > >This patch adds a validation in checkpatch tool, to check if a tracepoint is > >present in any new function added in cryptodev, ethdev, eventdev and > >mempool library. > > > >In this patch, the build_map_changes function is copied from check-symbol- > >change.sh to check-tracepoint.sh. The check-tracepoint.sh script uses > >build_map_changes function to create a map of functions. > >In the map, the newly added functions, added in the experimental section are > >identified and their definition are checked for the presence of tracepoint. The > >checkpatch return error if the tracepoint is not present. > > > >For functions for which trace is not needed, they can be added to > >devtools/trace-skiplist.txt file. The above tracepoint check will be skipped for > >them. > > > >Signed-off-by: Ankur Dwivedi Given the amount of string processing, it would be more readable in python. That is not a show stopper, just a suggestion.