From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
stable@dpdk.org, John Baldwin <jhb@FreeBSD.org>
Subject: [PATCH] freebsd/contigmem: fix function parameter list
Date: Mon, 22 May 2023 10:22:41 +0100 [thread overview]
Message-ID: <20230522092241.20773-1-bruce.richardson@intel.com> (raw)
Functions which take no parameters should explicitly have "(void)" as
the parameter list, rather than "()".
Reported upstream on FreeBSD ports collection [1].
[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org
Reported-by: John Baldwin <jhb@FreeBSD.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
kernel/freebsd/contigmem/contigmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/freebsd/contigmem/contigmem.c b/kernel/freebsd/contigmem/contigmem.c
index bd72f4d620..7dd87599d9 100644
--- a/kernel/freebsd/contigmem/contigmem.c
+++ b/kernel/freebsd/contigmem/contigmem.c
@@ -111,7 +111,7 @@ static struct cdevsw contigmem_ops = {
};
static int
-contigmem_load()
+contigmem_load(void)
{
char index_string[8], description[32];
int i, error = 0;
@@ -178,7 +178,7 @@ contigmem_load()
}
static int
-contigmem_unload()
+contigmem_unload(void)
{
int i;
--
2.39.2
next reply other threads:[~2023-05-22 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 9:22 Bruce Richardson [this message]
2023-05-22 16:02 ` Tyler Retzlaff
2023-05-24 16:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522092241.20773-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jhb@FreeBSD.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).