* [PATCH] freebsd/contigmem: fix function parameter list
@ 2023-05-22 9:22 Bruce Richardson
2023-05-22 16:02 ` Tyler Retzlaff
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2023-05-22 9:22 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable, John Baldwin
Functions which take no parameters should explicitly have "(void)" as
the parameter list, rather than "()".
Reported upstream on FreeBSD ports collection [1].
[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org
Reported-by: John Baldwin <jhb@FreeBSD.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
kernel/freebsd/contigmem/contigmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/freebsd/contigmem/contigmem.c b/kernel/freebsd/contigmem/contigmem.c
index bd72f4d620..7dd87599d9 100644
--- a/kernel/freebsd/contigmem/contigmem.c
+++ b/kernel/freebsd/contigmem/contigmem.c
@@ -111,7 +111,7 @@ static struct cdevsw contigmem_ops = {
};
static int
-contigmem_load()
+contigmem_load(void)
{
char index_string[8], description[32];
int i, error = 0;
@@ -178,7 +178,7 @@ contigmem_load()
}
static int
-contigmem_unload()
+contigmem_unload(void)
{
int i;
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] freebsd/contigmem: fix function parameter list
2023-05-22 9:22 [PATCH] freebsd/contigmem: fix function parameter list Bruce Richardson
@ 2023-05-22 16:02 ` Tyler Retzlaff
2023-05-24 16:03 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Tyler Retzlaff @ 2023-05-22 16:02 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, stable, John Baldwin
On Mon, May 22, 2023 at 10:22:41AM +0100, Bruce Richardson wrote:
> Functions which take no parameters should explicitly have "(void)" as
> the parameter list, rather than "()".
>
> Reported upstream on FreeBSD ports collection [1].
>
> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
>
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
>
> Reported-by: John Baldwin <jhb@FreeBSD.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] freebsd/contigmem: fix function parameter list
2023-05-22 16:02 ` Tyler Retzlaff
@ 2023-05-24 16:03 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2023-05-24 16:03 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, stable, John Baldwin, Tyler Retzlaff
22/05/2023 18:02, Tyler Retzlaff:
> On Mon, May 22, 2023 at 10:22:41AM +0100, Bruce Richardson wrote:
> > Functions which take no parameters should explicitly have "(void)" as
> > the parameter list, rather than "()".
> >
> > Reported upstream on FreeBSD ports collection [1].
> >
> > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
> >
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> >
> > Reported-by: John Baldwin <jhb@FreeBSD.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-24 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 9:22 [PATCH] freebsd/contigmem: fix function parameter list Bruce Richardson
2023-05-22 16:02 ` Tyler Retzlaff
2023-05-24 16:03 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).