From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70BEB42BA3; Fri, 26 May 2023 05:30:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E34B40A89; Fri, 26 May 2023 05:30:53 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id DA34740A87 for ; Fri, 26 May 2023 05:30:51 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-64d2e8a842cso379110b3a.3 for ; Thu, 25 May 2023 20:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685071851; x=1687663851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=v3zV7PLQ3r/IZigR4lRSwoPaZmat3/0U3hGm9ylaCcg=; b=5DUWnyteOgcfYClHuP+cI36cf4nF7LHj141I2La7mf34vugsA3fdiUWGyVGz4Bvb4P 3rpjWqCEYVwDtJm8ZluT6AMuwAUZFH8xxkDd6/AjQDmF/u+UXLAVWVbHtY81klVo8N1P dbxGKzP61z4imFGYozyjMFTbaJbYxttqRnhlNhWNf1iQZvhBUe4Gkfw22IMgZF3dCFb2 dQo6ckOGJIzVqzh1eF58J++bh1ijR/2PxqSjKAf6ao/Z4BtcOtfwEI0vEUQ62kiNZfho e9a4t5vSkUeN4YhEfiZwyt/dLALqBwhi1f4L7cFxbOkmHj9/PCqvjJ3caaz0DH180KSS lFzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685071851; x=1687663851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v3zV7PLQ3r/IZigR4lRSwoPaZmat3/0U3hGm9ylaCcg=; b=GM0WXAvoyPpF/x1F98CnKNl1TPmJWDxA8vvDkuFcx+/cb0TuvGQl2e+aiXaN4EYJWN RuYCdyLQRVxgBfX6gpMPy8afpI3zOePoJKiYNG3bhqfUbeJP7V49VnUh6Kzv5PPWJT09 he2VPTvhIsDJNtwJDNBD3o+QWmz3053Rpgup2ucnv3RJSY6s5BAVKNzGdNAaKg9fEK9h wSIKYeYVHxHedav2zltcjV1eyHVofYMmYsKeo9cli0fkFh6WkR7fFyJVelMy21Z/+dgf PWQ5Jm947oogCXM+xBkThtB1fNyTvSh0wy3Lw4Hw2SAvnnIL0hOsGVJPttUFYIlywU9g PK0g== X-Gm-Message-State: AC+VfDyxGgUr07zxw2njdrRMd4HsZA2ffUz4dDHnzPA9Mdd3dZlMRi4x /r8B3gc/G+IAcOjumYAnjNYy6A== X-Google-Smtp-Source: ACHHUZ5357PVP/2U1H/BkHsHOkzOnp2eJM5qWSFMnDJwvjGEZkoMzBpxerhPxACv30Or8P9MjOpZBA== X-Received: by 2002:a05:6a00:218b:b0:645:fc7b:63db with SMTP id h11-20020a056a00218b00b00645fc7b63dbmr1521941pfi.20.1685071851022; Thu, 25 May 2023 20:30:51 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id v2-20020aa78502000000b0063d2dae6247sm1814283pfn.77.2023.05.25.20.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 20:30:50 -0700 (PDT) Date: Thu, 25 May 2023 20:30:49 -0700 From: Stephen Hemminger To: Ajay Sharma Cc: Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , Long Li , "stable@dpdk.org" Subject: Re: EXTERNAL] [PATCH ] Add checks for the port capabilties Message-ID: <20230525203049.638180a6@hermes.local> In-Reply-To: References: <1682653009-19988-1-git-send-email-longli@linuxonhyperv.com> <1683336767-19526-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 26 May 2023 00:19:59 +0000 Ajay Sharma wrote: > + dev_info->max_rx_queues = RTE_MIN(priv->max_rx_queues, USHRT_MAX); > + dev_info->max_tx_queues = RTE_MIN(priv->max_tx_queues, USHRT_MAX); > + Please use UINT16_MAX instead of USHRT_MAX since that is the type of max_rx_queues. Both are the same size but best to be consistent.