From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E9A042BD3; Mon, 29 May 2023 15:12:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A08E42D56; Mon, 29 May 2023 15:12:22 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 9BCEC42D40; Mon, 29 May 2023 15:12:17 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVG7v0pwyzLqBy; Mon, 29 May 2023 21:09:15 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 29 May 2023 21:12:13 +0800 From: Dongdong Liu To: , , , , CC: , , , , Subject: [PATCH 09/11] net/hns3: make code more clean Date: Mon, 29 May 2023 21:09:38 +0800 Message-ID: <20230529130940.1501-10-liudongdong3@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20230529130940.1501-1-liudongdong3@huawei.com> References: <20230529130940.1501-1-liudongdong3@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dengdui Huang This patch modify the code that violates the coding standards. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 +-- drivers/net/hns3/hns3_rxtx.c | 10 +++------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c index 5d6f92e4bb..be1be6a89c 100644 --- a/drivers/net/hns3/hns3_regs.c +++ b/drivers/net/hns3/hns3_regs.c @@ -385,10 +385,9 @@ hns3_dfx_reg_cmd_send(struct hns3_hw *hw, struct hns3_cmd_desc *desc, hns3_cmd_setup_basic_desc(&desc[i], opcode, true); ret = hns3_cmd_send(hw, desc, bd_num); - if (ret) { + if (ret) hns3_err(hw, "fail to query dfx registers, opcode = 0x%04X, " "ret = %d.\n", opcode, ret); - } return ret; } diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 2493748683..cf04dc857e 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -751,7 +751,7 @@ hns3pf_reset_all_tqps(struct hns3_hw *hw) for (i = 0; i < hw->cfg_max_queues; i++) { ret = hns3pf_reset_tqp(hw, i); if (ret) { - hns3_err(hw, "fail to reset tqp, queue_id = %d, ret = %d.", + hns3_err(hw, "fail to reset tqp, queue_id = %u, ret = %d.", i, ret); return ret; } @@ -829,15 +829,13 @@ hns3_send_reset_queue_cmd(struct hns3_hw *hw, uint16_t queue_id, { struct hns3_reset_tqp_queue_cmd *req; struct hns3_cmd_desc desc; - int queue_direction; int ret; hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RESET_TQP_QUEUE_INDEP, false); req = (struct hns3_reset_tqp_queue_cmd *)desc.data; req->tqp_id = rte_cpu_to_le_16(queue_id); - queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1; - req->queue_direction = rte_cpu_to_le_16(queue_direction); + req->queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1; hns3_set_bit(req->reset_req, HNS3_TQP_RESET_B, enable ? 1 : 0); ret = hns3_cmd_send(hw, &desc, 1); @@ -855,15 +853,13 @@ hns3_get_queue_reset_status(struct hns3_hw *hw, uint16_t queue_id, { struct hns3_reset_tqp_queue_cmd *req; struct hns3_cmd_desc desc; - int queue_direction; int ret; hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RESET_TQP_QUEUE_INDEP, true); req = (struct hns3_reset_tqp_queue_cmd *)desc.data; req->tqp_id = rte_cpu_to_le_16(queue_id); - queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1; - req->queue_direction = rte_cpu_to_le_16(queue_direction); + req->queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1; ret = hns3_cmd_send(hw, &desc, 1); if (ret) { -- 2.22.0