DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jie Hai <haijie1@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>, <liudongdong3@huawei.com>
Subject: [PATCH 05/10] ethdev: support telemetry query Tx queue info
Date: Tue, 30 May 2023 17:05:05 +0800	[thread overview]
Message-ID: <20230530090510.56812-6-haijie1@huawei.com> (raw)
In-Reply-To: <20230530090510.56812-1-haijie1@huawei.com>

This patch support querying information of Tx queues.
The command is like:
--> /ethdev/tx_queue,0,0
{
  "/ethdev/tx_queue": {
    "host_threshold": 0,
    "prefetch_threshold": 0,
    "writeback_threshold": 0,
    "rs_threshold": 32,
    "free_threshold": 928,
    "deferred_start": "off",
    "offloads": [
      "MBUF_FAST_FREE"
    ],
    "queue_state": 1,
    "nb_desc": 1024,
    "burst_flags": 0,
    "burst_mode": "Vector Neon"
  }
}

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 lib/ethdev/rte_ethdev.c | 50 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 35c13df1c110..315334321cb3 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -7295,6 +7295,54 @@ eth_dev_handle_port_rxq(const char *cmd __rte_unused,
 	return ret;
 }
 
+static int
+eth_dev_handle_port_txq(const char *cmd __rte_unused,
+		const char *params,
+		struct rte_tel_data *d)
+{
+	struct rte_eth_thresh *tx_thresh;
+	unsigned long port_id, queue_id;
+	struct rte_eth_txconf *txconf;
+	struct rte_eth_txq_info qinfo;
+	struct rte_tel_data *offload;
+	int ret;
+
+	ret = parse_queue_params(params, false, &port_id, &queue_id);
+	if (ret != 0)
+		return ret;
+
+	ret = rte_eth_tx_queue_info_get(port_id, queue_id, &qinfo);
+	if (ret != 0)
+		return ret;
+
+	rte_tel_data_start_dict(d);
+	tx_thresh = &qinfo.conf.tx_thresh;
+	txconf = &qinfo.conf;
+	rte_tel_data_add_dict_uint(d, "host_threshold", tx_thresh->hthresh);
+	rte_tel_data_add_dict_uint(d, "prefetch_threshold", tx_thresh->pthresh);
+	rte_tel_data_add_dict_uint(d, "writeback_threshold", tx_thresh->wthresh);
+	rte_tel_data_add_dict_uint(d, "rs_threshold", txconf->tx_rs_thresh);
+	rte_tel_data_add_dict_uint(d, "free_threshold", txconf->tx_free_thresh);
+	rte_tel_data_add_dict_string(d, "deferred_start",
+			txconf->tx_deferred_start == 0 ? "off" : "on");
+
+	offload = rte_tel_data_alloc();
+	if (offload == NULL)
+		return -ENOMEM;
+
+	eth_dev_parse_tx_offloads(txconf->offloads, offload);
+	rte_tel_data_add_dict_container(d, "offloads", offload, 0);
+
+	rte_tel_data_add_dict_uint(d, "queue_state", qinfo.queue_state);
+	rte_tel_data_add_dict_uint(d, "nb_desc", qinfo.nb_desc);
+
+	ret = eth_dev_add_burst_mode(port_id, queue_id, false, d);
+	if (ret != 0)
+		rte_tel_data_free(offload);
+
+	return 0;
+}
+
 RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);
 
 RTE_INIT(ethdev_init_telemetry)
@@ -7322,4 +7370,6 @@ RTE_INIT(ethdev_init_telemetry)
 			"Returns flow ctrl info for a port. Parameters: unsigned port_id");
 	rte_telemetry_register_cmd("/ethdev/rx_queue", eth_dev_handle_port_rxq,
 			"Returns Rx queue info for a port. Parameters: unsigned port_id, unsigned queue_id (Optional if only one queue)");
+	rte_telemetry_register_cmd("/ethdev/tx_queue", eth_dev_handle_port_txq,
+			"Returns Tx queue info for a port. Parameters: unsigned port_id, unsigned queue_id (Optional if only one queue)");
 }
-- 
2.33.0


  parent reply	other threads:[~2023-05-30  9:08 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  9:05 [PATCH 00/10] support telemetry query ethdev info Jie Hai
2023-05-30  9:05 ` [PATCH 01/10] ethdev: support telemetry query MAC addresses Jie Hai
2023-06-01 14:39   ` Ferruh Yigit
2023-05-30  9:05 ` [PATCH 02/10] ethdev: support RxTx offload display Jie Hai
2023-05-30  9:05 ` [PATCH 03/10] ethdev: support telemetry query flow ctrl info Jie Hai
2023-05-30  9:05 ` [PATCH 04/10] ethdev: support telemetry query Rx queue info Jie Hai
2023-05-30  9:05 ` Jie Hai [this message]
2023-05-30  9:05 ` [PATCH 06/10] ethdev: add firmware version in telemetry info command Jie Hai
2023-05-30  9:05 ` [PATCH 07/10] ethdev: support telemetry query DCB info Jie Hai
2023-05-30  9:05 ` [PATCH 08/10] ethdev: support telemetry query RSS info Jie Hai
2023-05-30  9:05 ` [PATCH 09/10] ethdev: support telemetry query FEC info Jie Hai
2023-05-30  9:05 ` [PATCH 10/10] ethdev: support telemetry query VLAN info Jie Hai
2023-06-01 12:05 ` [PATCH 00/10] support telemetry query ethdev info Ferruh Yigit
2023-06-01 12:23   ` Jie Hai
2023-06-01 14:36 ` Ferruh Yigit
2023-06-05  6:19   ` Jie Hai
2023-06-07  7:41 ` [PATCH v2 00/13] " Jie Hai
2023-06-07  7:41   ` [PATCH v2 01/13] ethdev: fix incorrect argument of calloc Jie Hai
2023-06-07 11:35     ` Ferruh Yigit
2023-06-07  7:41   ` [PATCH v2 02/13] ethdev: extract telemetry codes to a file Jie Hai
2023-06-07 11:37     ` Ferruh Yigit
2023-06-07  7:41   ` [PATCH v2 03/13] ethdev: extract codes parsing port ID as a function Jie Hai
2023-06-07 11:37     ` Ferruh Yigit
2023-06-07  7:41   ` [PATCH v2 04/13] ethdev: support telemetry query MAC addresses Jie Hai
2023-06-07  7:42   ` [PATCH v2 05/13] ethdev: support RxTx offload display Jie Hai
2023-06-07  7:42   ` [PATCH v2 06/13] ethdev: support telemetry query flow ctrl info Jie Hai
2023-06-07  7:42   ` [PATCH v2 07/13] ethdev: support telemetry query Rx queue info Jie Hai
2023-06-07  7:42   ` [PATCH v2 08/13] ethdev: support telemetry query Tx " Jie Hai
2023-06-07  7:42   ` [PATCH v2 09/13] ethdev: add firmware version in telemetry info command Jie Hai
2023-06-07  7:42   ` [PATCH v2 10/13] ethdev: support telemetry query DCB info Jie Hai
2023-06-07  7:42   ` [PATCH v2 11/13] ethdev: support telemetry query RSS info Jie Hai
2023-06-07 14:08     ` Ferruh Yigit
2023-06-07  7:42   ` [PATCH v2 12/13] ethdev: support telemetry query FEC info Jie Hai
2023-06-07  7:42   ` [PATCH v2 13/13] ethdev: support telemetry query VLAN info Jie Hai
2023-06-07 11:40   ` [PATCH v2 00/13] support telemetry query ethdev info Ferruh Yigit
2023-06-08  2:01     ` Jie Hai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230530090510.56812-6-haijie1@huawei.com \
    --to=haijie1@huawei.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=liudongdong3@huawei.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).