From: Artemii Morozov <artemii.morozov@arknetworks.am>
To: dev@dpdk.org
Cc: Artemii Morozov <Artemii.Morozov@arknetworks.am>,
Andy Moreton <amoreton@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [PATCH] common/sfc_efx/base: set return code in case of the error
Date: Wed, 31 May 2023 11:08:10 +0400 [thread overview]
Message-ID: <20230531070810.93131-1-artemii.morozov@arknetworks.am> (raw)
From: Artemii Morozov <Artemii.Morozov@arknetworks.am>
If the prefix for the rss hash was not chosen the
ENOTSUP error should be returned.
Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
drivers/common/sfc_efx/base/efx_rx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c
index 68f42f5cac..61726a9f0b 100644
--- a/drivers/common/sfc_efx/base/efx_rx.c
+++ b/drivers/common/sfc_efx/base/efx_rx.c
@@ -937,8 +937,10 @@ efx_rx_qcreate_internal(
rss_hash_field =
&erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH];
- if (rss_hash_field->erpfi_width_bits == 0)
+ if (rss_hash_field->erpfi_width_bits == 0) {
+ rc = ENOTSUP;
goto fail5;
+ }
}
enp->en_rx_qcount++;
--
2.34.1
next reply other threads:[~2023-05-31 7:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 7:08 Artemii Morozov [this message]
2023-06-01 6:30 ` [PATCH v2] " Artemii Morozov
2023-06-01 15:48 ` Ferruh Yigit
2023-06-22 9:13 ` [PATCH v3] " Artemii Morozov
2023-06-22 9:25 ` Andrew Rybchenko
2023-06-22 9:31 ` [PATCH v4] " Artemii Morozov
2023-06-22 11:27 ` Ferruh Yigit
2023-06-22 12:31 ` [PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix Artemii Morozov
2023-06-22 13:13 ` Ferruh Yigit
2023-06-22 13:52 ` Artemii Morozov
2023-06-22 15:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531070810.93131-1-artemii.morozov@arknetworks.am \
--to=artemii.morozov@arknetworks.am \
--cc=amoreton@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).