DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 0/2] cleanup use of rte_strlcpy
Date: Wed, 31 May 2023 15:05:31 -0700	[thread overview]
Message-ID: <20230531220533.29910-1-stephen@networkplumber.org> (raw)

In DPDK API's rte_strlcpy() is not intended to be used directly.
It was introduced as a replacement for when operating system
libraries were missing strlcpy(). Over time it appears several
drivers and subsystems started using it directly, which is
inefficient since the wrapper uses snprintf().

This series makes sure that the only usage of rte_strlcpy()
is in rte_string_fns.h where it is needed.

Perhaps checkpatch should warn about other uses?

Stephen Hemminger (2):
  lib: replace rte_strlcpy() with strlcpy()
  drivers: don't use rte_strlcpy

 drivers/common/cnxk/roc_platform.h            |  2 +-
 drivers/mempool/cnxk/cnxk_mempool_telemetry.c |  2 +-
 drivers/net/cnxk/cnxk_ethdev_ops.c            |  4 +-
 drivers/net/mlx5/mlx5_testpmd.c               |  2 +-
 lib/eal/common/eal_common_memzone.c           |  2 +-
 lib/fib/rte_fib.c                             |  2 +-
 lib/fib/rte_fib6.c                            |  2 +-
 lib/hash/rte_thash.c                          |  4 +-
 lib/mempool/rte_mempool.c                     |  2 +-
 lib/mldev/mldev_utils.c                       | 40 +++++++++----------
 lib/rib/rte_rib.c                             |  2 +-
 lib/rib/rte_rib6.c                            |  2 +-
 12 files changed, 33 insertions(+), 33 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-05-31 22:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 22:05 Stephen Hemminger [this message]
2023-05-31 22:05 ` [PATCH 1/2] lib: replace rte_strlcpy() with strlcpy() Stephen Hemminger
2023-05-31 22:05 ` [PATCH 2/2] drivers: don't use rte_strlcpy Stephen Hemminger
2023-06-01 10:18 ` [PATCH 0/2] cleanup use of rte_strlcpy Bruce Richardson
2023-06-02 21:46   ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230531220533.29910-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).