From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EBA842C11; Fri, 2 Jun 2023 18:22:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F01D427F2; Fri, 2 Jun 2023 18:22:11 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 20145406B8 for ; Fri, 2 Jun 2023 18:22:09 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 6D0C020FCD5F; Fri, 2 Jun 2023 09:22:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6D0C020FCD5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1685722928; bh=ixUw4lQna/9ntlZbqArNQMEtTxwX0GTIlIAh9JK7gT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKqi8sOo55FFDyJZ7v2rispvzg1gDtewg84vyzv9nTvVh4DZyJg1CfjZtVFqIwOIL NknOJLietl5Hvm3o0jM+9aYuXwfW2kxNK3IICiC2Q036Rb0MYPBTgQKx3bvBelVGzQ ijkVyqqHvcQFmnou7T7qD6NY9GJbztdfxlEsXvv0= Date: Fri, 2 Jun 2023 09:22:08 -0700 From: Tyler Retzlaff To: "Zhang, Qi Z" Cc: David Marchand , "Richardson, Bruce" , "dev@dpdk.org" , "thomas@monjalon.net" Subject: Re: [PATCH 0/6] windows: remove most pthread lifetime shim functions Message-ID: <20230602162208.GA12490@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1679092460-9930-1-git-send-email-roretzla@linux.microsoft.com> <20230403053412.GB19270@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 01, 2023 at 12:23:39PM +0000, Zhang, Qi Z wrote: > > > > -----Original Message----- > > From: David Marchand > > Sent: Thursday, June 1, 2023 4:50 PM > > To: Richardson, Bruce ; Tyler Retzlaff > > > > Cc: dev@dpdk.org; thomas@monjalon.net; Zhang, Qi Z > > > > Subject: Re: [PATCH 0/6] windows: remove most pthread lifetime shim > > functions > > > > On Tue, Apr 18, 2023 at 11:21 AM Bruce Richardson > > wrote: > > > > > > On Sun, Apr 02, 2023 at 10:34:12PM -0700, Tyler Retzlaff wrote: > > > > early review if possible please, would like to have this in from the > > > > start of 23.07 to work against. > > > > > > > > thanks! > > > > > > > > > > Don't see any problems with this set. > > > > Drivers maintainers were not copied (Tyler, git send-email has options --to- > > cmd or --cc-cmd to which you can pass ./devtools/get-maintainers.sh). > > I pinged Qi during the maintainers call today. > > Hi Tyler & David: > > The patchset looks good to me. > > I have just one question regarding the patch set targets, which include PMD iavf, ice, and ixgbe. However, I noticed that some other Intel PMDs like ipn3ke still use rte_ctrl_thread_create and have not been replaced. The series really isn't about rte_ctrl_thread_create, it just happens that for code built on Windows that code needs to stop using rte_ctrl_thread_create because it references the pthread shim that is being removed. At some point in the future (it's lower priority right now) I will submit a series that converts all rte_ctrl_thread_create -> rte_control_thread_create since rte_ctrl_thread_create is being deprecated. > > I assume that this replacement is specifically intended for PMDs that support Windows, as PMDs with the "Windows" feature should be covered. However, I didn't see the "Windows" feature enabled for iavf PMD, even though it is included in the patch set. > > Could you help me understand the criteria used for determining which PMDs should be included in this replacement? Yes, you are correct the patch is intended to address PMDs / code built on Windows specifically. I just re-verified that iavf is being built for Windows. If I remove the iavf patch from the series I get the following warning, so that is why I adapted the iavf PMD code. [249/749] Compiling C object drivers/libtmp_rte_net_iavf.a.p/net_iavf_iavf_vchnl.c.obj ../drivers/net/iavf/iavf_vchnl.c:162:2: warning: implicit declaration of function 'pthread_join' is invalid in C99 [-Wimplicit-function-declaration] pthread_join(handler->tid, NULL); > > Thanks > Qi > > > > > The changes are straightforward and lgtm. > > For the series, > > Reviewed-by: David Marchand I think with the above explained the series should be okay as is, no changes required if Qi is okay with the above explanation. > > > > > > -- > > David Marchand >