From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0A3342C40; Tue, 6 Jun 2023 17:38:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 527F64067B; Tue, 6 Jun 2023 17:38:09 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 62F4B40223 for ; Tue, 6 Jun 2023 17:38:07 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b011cffef2so58171985ad.3 for ; Tue, 06 Jun 2023 08:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686065886; x=1688657886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/jBAKE2o9xIkPwVU9/eI8NdWz5U8O9nUH54F2bxSsVQ=; b=rd6rz+ndsXAawJ449AQp1IZB+PEz0GcKS0MiYj/SN4FBCIZRtKnAIm+cBm5ex3gtnf RK7yj69/vS4hGXv51qUXn4SDMkSNhqd0RLNH16rk8rm4ZtGOqxHBN8spIjaGA+ycl/VU 6cDGvjvt3pJZZdDahJ2YgsCDqpl0TlBuGS1O6SJFDzgO7o6sRjw0nsYlHozaOLlZUCLI l0gUqxNMHHAPo96B4CBt7p0SlDE05njuFjJaxlFbIkPSG1c399KIuCQo83JmVuYTchrJ NFqco1eC9UHgBFfa+7nLCFOm4kpD9vM/tgKfu1Wc8OzOsL/OD6iBWmHc0JSPvNocEt72 2Nvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686065886; x=1688657886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/jBAKE2o9xIkPwVU9/eI8NdWz5U8O9nUH54F2bxSsVQ=; b=L4dpHH8RzusvM+pOzlAE9FWyegad3I5NmB2es2QdinEvra5NhqBUftXBYQBe1KTbpE ZB/lDmDbCUKsbdYq7XEggRS0s8f2Qzr27Noy55KhN+fR5O1x1G1gFoZpqnKXEOcfVp+e 4pu3dhWhYFXcOVDsgobzwqlBU2iGm9Vfww4wJQQjlKWnUbqOWqA+E5XHTrpejp/vvHuD xeHtvuefayYKqyArkMwKc4ucQ12tNfQLTJAlWBg/0dUcHQwOry/4gAMZgMc/MdT4hLho E46yzmoKBKwVt41tgvXIYbqATbDIUjVkyM4LE0e0DPLXzNjz8stYYFpjUfIOKAbrHwgK 2YgQ== X-Gm-Message-State: AC+VfDw8HQBTAoxdAPw3Av5yyWBd/cgz71Rdpdd8bhKsgHHz9gE/vys6 Ik7x5lPpLimjqP4fZayacK309A== X-Google-Smtp-Source: ACHHUZ4qbSWB6yM+le7obe0gPStkmPKFe4vb7uLz8Fnbz8TAGnlqBrVBHjaD+h3ZH+kB0AT+Bm1VEA== X-Received: by 2002:a17:902:e551:b0:1b2:461:8d8a with SMTP id n17-20020a170902e55100b001b204618d8amr3053381plf.35.1686065886500; Tue, 06 Jun 2023 08:38:06 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id t1-20020a170902e84100b001b04949e0acsm8691475plg.232.2023.06.06.08.38.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 08:38:06 -0700 (PDT) Date: Tue, 6 Jun 2023 08:38:04 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, thomas@monjalon.net, Andrew Rybchenko Subject: Re: [PATCH] ethdev: validate reserved fields Message-ID: <20230606083804.4c4f8b86@hermes.local> In-Reply-To: <2365bf8b-aafd-872b-2b13-8ba09d985747@amd.com> References: <20230525203942.129413-1-stephen@networkplumber.org> <2365bf8b-aafd-872b-2b13-8ba09d985747@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 6 Jun 2023 16:24:36 +0100 Ferruh Yigit wrote: > No objection on validating reserved fields, but if any application > passing not zero values before (I think this was possible), it will > break with this change, so can we get this patch in this release? > > Or should it need to wait ABI break release? > If we will wait v23.11, perhaps this should be applied to all structs > with reserved fields, and may be good to add a deprecation notice in > this release, what do you t Yes, do this in 23.11 (early in merge cycle). Did ethdev because it is heavily used, and easy to test and validate.