From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
Qin Ke <qin.ke@corigine.com>,
Chaoyong He <chaoyong.he@corigine.com>,
stable@dpdk.org
Subject: [PATCH] net/nfp: fix callback function pointer of disabling promisc
Date: Thu, 8 Jun 2023 11:07:56 +0800 [thread overview]
Message-ID: <20230608030756.814540-1-chaoyong.he@corigine.com> (raw)
From: Qin Ke <qin.ke@corigine.com>
The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops
and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not
nfp_net_promisc_enable, fix it.
Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port")
Cc: Chaoyong He <chaoyong.he@corigine.com>
Cc: stable@dpdk.org
Signed-off-by: Qin Ke <qin.ke@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
index 6b4ba5b9a2..3225a4b84a 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -518,7 +518,7 @@ static const struct eth_dev_ops nfp_flower_pf_repr_dev_ops = {
.stats_reset = nfp_flower_repr_stats_reset,
.promiscuous_enable = nfp_net_promisc_enable,
- .promiscuous_disable = nfp_net_promisc_enable,
+ .promiscuous_disable = nfp_net_promisc_disable,
.mac_addr_set = nfp_flower_repr_mac_addr_set,
.fw_version_get = nfp_repr_firmware_version_get,
@@ -540,7 +540,7 @@ static const struct eth_dev_ops nfp_flower_repr_dev_ops = {
.stats_reset = nfp_flower_repr_stats_reset,
.promiscuous_enable = nfp_net_promisc_enable,
- .promiscuous_disable = nfp_net_promisc_enable,
+ .promiscuous_disable = nfp_net_promisc_disable,
.mac_addr_set = nfp_flower_repr_mac_addr_set,
.fw_version_get = nfp_repr_firmware_version_get,
--
2.39.1
next reply other threads:[~2023-06-08 3:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 3:07 Chaoyong He [this message]
2023-06-08 14:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608030756.814540-1-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=qin.ke@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).