DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yahui Cao <yahui.cao@intel.com>
Cc: thomas@monjalon.net, ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bus/vdev: add warning for duplicated vdev name
Date: Sat, 10 Jun 2023 08:51:38 -0700	[thread overview]
Message-ID: <20230610085138.17549b86@hermes.local> (raw)
In-Reply-To: <20181129071608.20820-1-yahui.cao@intel.com>

On Thu, 29 Nov 2018 15:16:08 +0800
Yahui Cao <yahui.cao@intel.com> wrote:

> If duplicated vdev name is detected, print out a warning message.
> 
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> ---
>  drivers/bus/vdev/vdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 9c66bdc78..ff2db7d3f 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -462,6 +462,8 @@ vdev_scan(void)
>  		if (find_vdev(devargs->name)) {
>  			rte_spinlock_recursive_unlock(&vdev_device_list_lock);
>  			free(dev);
> +			VDEV_LOG(WARNING, "duplicated vdev name %s detected!",
> +				devargs->name);
>  			continue;
>  		}
>  

Do you have an example of this?

It should be an error and have the scan fail.

      parent reply	other threads:[~2023-06-10 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29  7:16 Yahui Cao
2018-12-19  2:26 ` Thomas Monjalon
2018-12-21  6:57   ` Yahui Cao
2023-06-10 15:51 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230610085138.17549b86@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    --cc=yahui.cao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).