From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B657242C7F; Sat, 10 Jun 2023 17:51:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9550940DD8; Sat, 10 Jun 2023 17:51:42 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 37C4540A8B for ; Sat, 10 Jun 2023 17:51:41 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1b3a9e5bf6aso2230745ad.3 for ; Sat, 10 Jun 2023 08:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686412300; x=1689004300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SngdkXz3CozE99hf+2L8d5OhDEvawo0L/7mmodNXjLY=; b=yM9wB8IXewmX86+dqah2tYnMgSK6yiTqF6lNzm83Tz7d5bXL3yGVjLPVYNPumU5y3O lESbqg0Dijta57fNJVeOdegwhoRbqIYhB+xm44ldrgqpK8L3Bzlx+AJojnM48fPVXEg7 0tVyX1wUkaYeOpj+8Qo25KWgxXU5gs7aeaqvnoAPaXxicyezxTV3UwQ1oc60VGR5vcnj 77+8hVPghrExZCxTxOM562RfWESSYxEaD5E/f9mMtOHVOaMqQFISYqKE2mPHbV6hqrqS usCqS01YcjbE+OGD6xop9FLXl5aDXSXy8OguTCSemCRMIFX3LYowxuhSxq9RGvqYnitB bzOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686412300; x=1689004300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SngdkXz3CozE99hf+2L8d5OhDEvawo0L/7mmodNXjLY=; b=iy46oxVVS+mpkB0RLRW2ZtZF3MbBTdtbrWdB1NUwl2N5/gxlWfAXqre47kHq7BeK8J zmNctwaSsgupJ4rTksE8Uj+rlIwnI/hM8R5I2YYvkly4PTqyA8sJYQl0jW9e1Uf1sIMr 5ZYIuKSAmgvJ4B0CFN/WmBXwbHblx3h1dCI3HhHn27KD37QonCgrWjOvntlLuEi1Lzq8 cEV6xI1J+NMpdYV64W26IamCvUJgCIFWiknpLte3a5s0wCUyzpcpJ1xuvp52quzn8V26 0aHp3v6FvLzdkTMsFNid/sWRo74BHyEPyYlAmSkor4OwWNacAG6G2e3vUlsx8MxFAjKu j3WQ== X-Gm-Message-State: AC+VfDw+uWkN3HApJALFSHYXWzkofUhgXzUjwv0czQBwGC8scGcilfy8 RLunQ/BTK0vBB+S2tZqwfltLqQ== X-Google-Smtp-Source: ACHHUZ75gjuX4E7a/rWvXUEUsoFCUa8KXF9Mm8axQV5TKqGNoZybHZlOF+E4hp2s1A1vxUei8IWB/Q== X-Received: by 2002:a17:903:18a:b0:1a6:4b60:3195 with SMTP id z10-20020a170903018a00b001a64b603195mr2266551plg.66.1686412300212; Sat, 10 Jun 2023 08:51:40 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id w17-20020a170902e89100b001affb590696sm5084919plg.216.2023.06.10.08.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 08:51:40 -0700 (PDT) Date: Sat, 10 Jun 2023 08:51:38 -0700 From: Stephen Hemminger To: Yahui Cao Cc: thomas@monjalon.net, ferruh.yigit@intel.com, dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] bus/vdev: add warning for duplicated vdev name Message-ID: <20230610085138.17549b86@hermes.local> In-Reply-To: <20181129071608.20820-1-yahui.cao@intel.com> References: <20181129071608.20820-1-yahui.cao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 29 Nov 2018 15:16:08 +0800 Yahui Cao wrote: > If duplicated vdev name is detected, print out a warning message. > > Signed-off-by: Yahui Cao > --- > drivers/bus/vdev/vdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c > index 9c66bdc78..ff2db7d3f 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -462,6 +462,8 @@ vdev_scan(void) > if (find_vdev(devargs->name)) { > rte_spinlock_recursive_unlock(&vdev_device_list_lock); > free(dev); > + VDEV_LOG(WARNING, "duplicated vdev name %s detected!", > + devargs->name); > continue; > } > Do you have an example of this? It should be an error and have the scan fail.