From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0391F42C74; Sun, 11 Jun 2023 04:52:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4018B410F1; Sun, 11 Jun 2023 04:52:53 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 1498D400D5 for ; Sun, 11 Jun 2023 04:52:51 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-54290603887so1487477a12.1 for ; Sat, 10 Jun 2023 19:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686451971; x=1689043971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hh6gdm4uz1MMEGdcFhrOF+n0OZ1GA2GrRk0DJ5JS2Ns=; b=VGI34MZ4bQUDKg7j9moaRq8W4l2iruvM9Yz7C6S0M6yXZLT0tOb2k3J0Y6/K71LYX9 27hCYY7XIEbxbsRzIU1fnYYWL2SQGZsomCc61SKJqiG7HBXdlKcTC+UcACKrjmV2hbt2 BZYmwpoG/GLvMdvtb2Y8pM/2Tjf8Ut7nHvh1U0iUCht+rxnKnLGmgdUau9/Z9EtcN7J4 AEvc4Wnndq9GpLsEuxchTG5wfhDnAYcUbCjbLk/t9sKt309EGot/ZGlQEKSQ9BIq5mWj DxMIUei7mzUsmNy+B6KQdIsDw0stYr2q7xeb40ck+EwK/B6Iypl7liYC4X40NqTZT+F0 2DJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686451971; x=1689043971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hh6gdm4uz1MMEGdcFhrOF+n0OZ1GA2GrRk0DJ5JS2Ns=; b=NiMaGel7K7ku9XR49ccvGmjCYUaVg/MrvQ7TNCL2UoOZrzzBltRw4728Vh77zyzydM EHpyDT0EU4hea+OiyK5qhOOqFaDsQBV8bxCOtkxKIqXW1McCKsJ4kWyzAmmtVO3oCQf2 Vh0IZzKXlq4nmLfCyEQY2rd9lPAHb4eu/og7FTjBfNcxsnfOFp+0BgZkBjisycFZZ+V4 F4N+FTyk2I+TBPKm/bJRIgFkWLVhHiHKRG7I0Xk3omxH27eb5O/3y9iNju7Z5xac+8jC nvNJckPyc+iXZSoO2M8Ji8FPIoZJHaUoSOkNtw3EqaR171xdHbkTykSlWxorvdUw2Rb3 aZzg== X-Gm-Message-State: AC+VfDy1D/2lI/OTKpC5a0oNgR4cl6RgpG50HOCRCC+N5Epl9UoWmbVM zepbd56bL7b1EDDsDtCuJNUiHw== X-Google-Smtp-Source: ACHHUZ42sixeVPKERiCDQwWxRD6xX4GBVE73AElWBOFisPqu8R65yQZjrmma/prM37YguItvDVzV7w== X-Received: by 2002:a17:90a:38e1:b0:256:857f:823d with SMTP id x88-20020a17090a38e100b00256857f823dmr4347159pjb.48.1686451971010; Sat, 10 Jun 2023 19:52:51 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d24-20020a17090ac25800b002567501040csm6814500pjx.42.2023.06.10.19.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 19:52:50 -0700 (PDT) Date: Sat, 10 Jun 2023 19:52:49 -0700 From: Stephen Hemminger To: "Zhang, Qi Z" Cc: Thomas Monjalon , "dev@dpdk.org" , "Stojaczyk, Dariusz" , "stable@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] eal: remove useless checks for already probed device Message-ID: <20230610195249.5a20af69@hermes.local> In-Reply-To: <039ED4275CED7440929022BC67E706115334BEC4@SHSMSX103.ccr.corp.intel.com> References: <20190302024253.15594-1-thomas@monjalon.net> <20190302024253.15594-2-thomas@monjalon.net> <039ED4275CED7440929022BC67E706115334BEC4@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 13 Mar 2019 13:46:01 +0000 "Zhang, Qi Z" wrote: > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Saturday, March 2, 2019 10:43 AM > > To: dev@dpdk.org > > Cc: Stojaczyk, Dariusz ; Zhang, Qi Z > > ; stable@dpdk.org > > Subject: [PATCH 1/3] eal: remove useless checks for already probed device > > > > The function eal_dev_hotplug_request_to_secondary() never returns -EEXIST > > result. The case of already probed device is filtered out. > > > > The test in __handle_secondary_request() was always true. > > The test in rte_dev_probe() was never true, and that's fine not returning -EEXIST > > if device is already attached in secondary processes. > > I didn't get this. > eal_dev_hotplug_request_to_secondary() never return -EEXIST, but req->result could be -EEXIST. > > This happens when secondary try to attach an already attached device > (__handle_primary_request --> local_dev_probe --> dev->bus->plug ) This seems to be the outstanding question on this old patch. Is this possible? If so then the original code is ok, and patch is not required.