From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: olivier.matz@6wind.com, ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH] kvargs: add match count inside processing
Date: Sun, 11 Jun 2023 19:32:50 -0700 [thread overview]
Message-ID: <20230611193250.07257ef9@hermes.local> (raw)
In-Reply-To: <20181130003938.27964-1-thomas@monjalon.net>
On Fri, 30 Nov 2018 01:39:38 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> After processing a kvlist in rte_kvargs_process(),
> it may be needed to loop again over kvlist, in order to know
> whether the key is matched or not, as done with rte_kvargs_count().
>
> In order to simplify implementation of kvargs checks,
> a new pointer parameter is added to get the match count from
> the function rte_kvargs_process().
>
> This count could have been returned as a positive value of the function,
> but it would change also the meaning of "return 0".
> It looks simpler to keep return code as 0 or negative,
> and add a dedicated output parameter for counting purpose.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>
> This RFC is not complete: the calls to rte_kvargs_process()
> in the drivers must be updated with the new parameter,
> and simplified if rte_kvargs_count() is used.
This is not a bad idea, but the patch was never completed for over 5 years.
By now, not sure what more needs to do or if anyone cares.
If there still is a use case, then rebase and resubmit.
Will mark this one as changes needed.
prev parent reply other threads:[~2023-06-12 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 0:39 Thomas Monjalon
2023-06-12 2:32 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230611193250.07257ef9@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).