From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB61042C91; Mon, 12 Jun 2023 04:32:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DFEE42D43; Mon, 12 Jun 2023 04:32:54 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 1E45642D39 for ; Mon, 12 Jun 2023 04:32:53 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-655d1fc8ad8so3157873b3a.1 for ; Sun, 11 Jun 2023 19:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686537172; x=1689129172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vDxVVpPA+UUTzgEd5XWydcBOdekY/OKBqVJls05yl0s=; b=4wOw30VQb4+Hj0nucJcZ9LxF9JYV9xzZ8/CwPm+nTvcMAsNQVKAPi4t9SxUX6f5Y1d gY279BdEk8+Rm9UaKdY5TxV7fsZHlU01PmTQmv8kAitYQXmflrI9OjglTzTuzF2BgMe4 gZ3/kqeJXSN3WPHMT4P2oMLlO71ctS1Owt5Aw2cfArTxsqEc+tiI58biLpUu+JYqqFts gZD/EOtDDNBa/NfIQ5OutgcDXZ3d4EzPaWst5+d6XbtknL6N5hHzm5R+wYR4od2whIYf sXOYU1jVka34lTWP1y/k3pvm2bhKoLBQDgV6uh7epFXzUiZQqqHpKfQwxV6aNdCtIuL4 LiBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686537172; x=1689129172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vDxVVpPA+UUTzgEd5XWydcBOdekY/OKBqVJls05yl0s=; b=KlMf6c+h6AuKW3zsmhZ5SwELZ8wx2IS1t6lMel3Xw1WW/5SK50iVYRXfIqNVpHAIIk ruCQ03ZteLDXwb14Cft+Q+ZeXG1EfCP3iYfCqJUzrIPPqtI6PO22dnTceEurslfT6/ev yrKkOLt0kL/LsXWBsHmYbND0YuByXjwgLSfPAlNQufPkBWA/xYJhaWZfHbX0bTX8+N/D vU+OX/b99wy+/RzLlMw3grTC9YdJy+zLJ054zvCT9OeYcIr+TTZhzFldnS13RAmjFJE3 TI4r64oFdhaNllSNGhMxvb2TNDT301Vxn82yICLEPUBbc3er9Fblvt1HH69X77vI+KGX +vvg== X-Gm-Message-State: AC+VfDx317eqcMqZaMGsS5Ue/MEPBvl1NKqJcnDpbbUoIGF84Bmb5g4v ivu9gEHD0xN57fiY5NWTKFKchA== X-Google-Smtp-Source: ACHHUZ4hG1zSwpvgyT+lDX01sJK+W+59uZ4RxmL8ehXUZJHSDrHAXn2kK36VG7mnGFC8t4+0DbUAEw== X-Received: by 2002:a05:6a00:23c2:b0:647:e45f:1a4c with SMTP id g2-20020a056a0023c200b00647e45f1a4cmr10921189pfc.11.1686537172249; Sun, 11 Jun 2023 19:32:52 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e20-20020a62ee14000000b00640f51801e6sm3864238pfi.159.2023.06.11.19.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jun 2023 19:32:52 -0700 (PDT) Date: Sun, 11 Jun 2023 19:32:50 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: olivier.matz@6wind.com, ferruh.yigit@intel.com, dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH] kvargs: add match count inside processing Message-ID: <20230611193250.07257ef9@hermes.local> In-Reply-To: <20181130003938.27964-1-thomas@monjalon.net> References: <20181130003938.27964-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 30 Nov 2018 01:39:38 +0100 Thomas Monjalon wrote: > After processing a kvlist in rte_kvargs_process(), > it may be needed to loop again over kvlist, in order to know > whether the key is matched or not, as done with rte_kvargs_count(). > > In order to simplify implementation of kvargs checks, > a new pointer parameter is added to get the match count from > the function rte_kvargs_process(). > > This count could have been returned as a positive value of the function, > but it would change also the meaning of "return 0". > It looks simpler to keep return code as 0 or negative, > and add a dedicated output parameter for counting purpose. > > Signed-off-by: Thomas Monjalon > --- > > This RFC is not complete: the calls to rte_kvargs_process() > in the drivers must be updated with the new parameter, > and simplified if rte_kvargs_count() is used. This is not a bad idea, but the patch was never completed for over 5 years. By now, not sure what more needs to do or if anyone cares. If there still is a use case, then rebase and resubmit. Will mark this one as changes needed.