From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 772A842C50; Mon, 12 Jun 2023 18:23:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69BD441138; Mon, 12 Jun 2023 18:23:08 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id B794D40698 for <dev@dpdk.org>; Mon, 12 Jun 2023 18:23:06 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1b3c4c1fbd7so9171745ad.2 for <dev@dpdk.org>; Mon, 12 Jun 2023 09:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686586986; x=1689178986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=q0pOtmyv/H4i1bLHe8FjEs5NDmjq0NuT4Nxn904zQEg=; b=lz2awYDQVx0enUzSPAnu6SwYtZ/t9cvqoNM+GYJG8QHSq7yStJxvaQFLegECQdgT1J aECLFAYSpft0M/AAi2CdVo5fBF5AcDBFW6JIfgSUKXPwS8dofAeKp+qEnfUn1y43D12D a3zie3NUcTpF7512jG6Ve9EgeziXcLBrJVMlYoCUX076dgktMFHetXdtuKUoDEqESAWM SwJYf2I35ssFiWtH+wKHxu8d412klk04Tx+8LSlc9QV/sY5pPjEuerosFAOnMpknuY16 K8//EWj5Aj8figKcXnc4g48Au6R+1fT+lT/bfsdmgLA8bk3apvAm31A9nOZ3UCMQ5qrd BwbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686586986; x=1689178986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q0pOtmyv/H4i1bLHe8FjEs5NDmjq0NuT4Nxn904zQEg=; b=Rl9+ms4D8Q1rKs+C/1L1vgmuhfSVMlxlgagWxYM+DSPT/jxG0gztOvLap8fOECcZa5 nWsQrNZjnWK3E4DGCu8ZKPWyDIOBWx5GzM6nQ5aZ1BJHTKTc08/b8rgXAVyIstWg+SjV Hapgx4mRWwQ9ERGi5z8M6avQi7MBxq5ksYQrn1LFjecTGyAR2Dm/SiBH/MMtOueUF17g E+DtBehJi4EX+FfaydTWIEeHpn63R2HiUjaKamXxxfK1ncNnWQoPtGy3v98QvpfbW8ug eg4aU+itEI8tURwq7Nn0slN+UrY5OWJnAfYQ0cXzfqek9mLkWcZluhaUSDdux2//E2L4 V/Nw== X-Gm-Message-State: AC+VfDxeBAl41lGqNGuYSngzapedbc2ITvX2KuGlk3wJXnf96c3vZJaB bw/38vC/PeDXnWM4actBvfrgpA== X-Google-Smtp-Source: ACHHUZ5U4paEnI9AplOPclIOa8EUUXodioMkJCUHfOZx7WZygbHMoIo0jtmXoaSh1SuUzOY49mFlpA== X-Received: by 2002:a17:903:41c8:b0:1b3:d759:d2e1 with SMTP id u8-20020a17090341c800b001b3d759d2e1mr1538078ple.5.1686586985780; Mon, 12 Jun 2023 09:23:05 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id i12-20020a17090332cc00b001a194df5a58sm8461183plr.167.2023.06.12.09.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 09:23:05 -0700 (PDT) Date: Mon, 12 Jun 2023 09:23:03 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> Cc: Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, Igor Russkikh <igor.russkikh@aquantia.com>, Pavel Belous <pavel.belous@aquantia.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>, John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Wang, Xiao W" <xiao.w.wang@intel.com>, Ziyang Xuan <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>, Guoyang Zhou <zhouguoyang@huawei.com>, "Wei Hu (Xavier)" <xavier.huwei@huawei.com>, "Min Hu (Connor)" <humin29@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, "Xing, Beilei" <beilei.xing@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Yang, Qiming" <qiming.yang@intel.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, "Wang, Zhihong" <zhihong.wang@intel.com>, "Ye, Xiaolong" <xiaolong.ye@intel.com>, Yong Wang <yongwang@vmware.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one Message-ID: <20230612092303.1731bfe4@hermes.local> In-Reply-To: <57e65973-6f93-69f0-af6d-890118f0cfad@partner.samsung.com> References: <20200417215739.23180-1-l.wojciechow@partner.samsung.com> <a6627818-c471-221f-ebe2-bd92d4d434f5@partner.samsung.com> <20200420171130.GA1719@bricha3-MOBL.ger.corp.intel.com> <7682483.vcMjziH8VY@thomas> <CGME20200420173033eucas1p263547727ddcafbf5d4120070dec1e398@eucas1p2.samsung.com> <20200420173015.GC1719@bricha3-MOBL.ger.corp.intel.com> <57e65973-6f93-69f0-af6d-890118f0cfad@partner.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 20 Apr 2020 19:34:43 +0200 Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> wrote: > > Note, this means that you need to ensure all debug printouts from libs and > > drivers are using the RTE_LOG macros so can be runtime controlled. I think > > that may be some distance from reality right now. > > > > Even if we do want all debug enabled from one flag, I'm still not 100% > > convinced that the existing debug flag is the way to do, since it only adds > > debug info to binary without affecting code generation. > OK, I see that there are different opinions on what shape the debug flag > should look like. > So I think, I'll hold on work on any implementation until we all agree, > what do we want. > > @Bruce: What code generation do you have on mind? This patchset seems stagnated by good intentions but no later effort. Agree that having: - a global flag for all debugs enabled would be good. - CI should do a build with that flag turned on. This will check that debug code actually works and is not so verbose that it can't run (which is often the case now). But current patchset doesn't do that. So leaving final disposition as "Changes requested" and someone can pick it up if they want to continue.