DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vipin Varghese <vipin.varghese@intel.com>
Cc: john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org,
	thomas@monjalon.net, sanjay.padubidri@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] doc/testpmd: update compile steps for bpf examples
Date: Mon, 12 Jun 2023 09:31:20 -0700	[thread overview]
Message-ID: <20230612093120.2a838715@hermes.local> (raw)
In-Reply-To: <20190610054121.83723-1-vipin.varghese@intel.com>

On Mon, 10 Jun 2019 11:11:21 +0530
Vipin Varghese <vipin.varghese@intel.com> wrote:

> Add note in the missing arguments for compiling BPF examples.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> 
> ---
> 
> V3:
>  - update the dependency for DPDK and others - Thomas Monjalon
> 
> V2:
>  - ACK for documentation - John McNamara
>  - move to compile section - Thomas Monjalon
> ---
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index cb83a3ce8..09cabec8c 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4651,6 +4651,12 @@ For example:
>     cd examples/bpf
>     clang -O2 -target bpf -c t1.c
>  
> +.. note::
> +
> +   To build DPDK based example, appropriate include and library path is to be
> +   passed to compiler. For other examples, corresponding dependencies is to be
> +   passed for include and libraries.
> +
>  Then to load (and JIT compile) t1.o at RX queue 0, port 1:
>  
>  .. code-block:: console

I am ok with this but the wording is so generic it doesn't really help
the user. A real example on a real distribution would be better.
Could someone update this patch and resubmit it? Or better yet
just have a make or meson script in examples/bpf?


      reply	other threads:[~2023-06-12 16:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07  8:41 [dpdk-dev] [PATCH] " Vipin Varghese
2019-05-07  8:41 ` Vipin Varghese
2019-05-07 15:07 ` Mcnamara, John
2019-05-07 15:07   ` Mcnamara, John
2019-05-09 22:31 ` Thomas Monjalon
2019-05-09 22:31   ` Thomas Monjalon
2019-05-10  1:41   ` Varghese, Vipin
2019-05-10  1:41     ` Varghese, Vipin
2019-05-23 13:47 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2019-05-29 11:17   ` Thomas Monjalon
2019-05-30 15:40     ` Varghese, Vipin
2019-06-10  5:41   ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2023-06-12 16:31     ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612093120.2a838715@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=sanjay.padubidri@intel.com \
    --cc=thomas@monjalon.net \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).