From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66ED242CAC; Wed, 14 Jun 2023 04:37:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 408A042BFE; Wed, 14 Jun 2023 04:37:08 +0200 (CEST) Received: from smtpbg154.qq.com (smtpbg154.qq.com [15.184.224.54]) by mails.dpdk.org (Postfix) with ESMTP id 886304161A; Wed, 14 Jun 2023 04:37:04 +0200 (CEST) X-QQ-mid: bizesmtp73t1686710220tcb95mxe Received: from wxdbg.localdomain.com ( [183.159.171.58]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 14 Jun 2023 10:36:59 +0800 (CST) X-QQ-SSF: 01400000000000J0Z000000A0000000 X-QQ-FEAT: xqT8U4SkSpjbkpRKp9dOY9ap/A6TVAMMxc8oBW9RC3OH4VniQC4qAYxVvlPaG BKEagk2nDH7Dnb0XTryo8W58ReeYj/Fbx6bawKTm6eNOBxBwfs5ks9is++qgEuB1XvTW1d3 acc7xcGCWOGKKZf9k4xjC1bxWFWKAs7V3bVY2D7r07+SYAkkl82OoFflqKF/1MIx66lbp2O XvYP6KqChUxo1WITN/vxquAGklIm75MK0a2VCBzeWRdjTT1T87Og18Q2yKQG//eRjln/RiD vhj+9ZBLaIqG8ea+LnAf6JwRXxp4VqxXQIpX95QBsgbv/8UpHTPPbUcYIdTEyALfEcl7zXw rmsAhcDBpaJmZVp4vO1o0zFM8aFanzoCAEEEwe1zLgvrzhfD4m2vdDd5bWxrA== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 15441106242337967353 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 2/9] net/txgbe: fix interrupt enable mask Date: Wed, 14 Jun 2023 10:34:22 +0800 Message-Id: <20230614023429.1002071-3-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230614023429.1002071-1-jiawenwu@trustnetic.com> References: <20230614023429.1002071-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When using no LSC mode, GPIO interrupt can still cause txgbe_dev_interrupt_delayed_handler() to be called, with TXGBE_FLAG_NEED_LINK_UPDATE to be set. So add a LSC condition on intr->mask_misc. Fixes: 2fc745e6b606 ("net/txgbe: add interrupt operation") Fixes: d3bb4a04eac1 ("net/txgbe: add SFP hotplug identification") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index a3d7461951..5eff1a766e 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -3232,7 +3232,8 @@ txgbe_dev_interrupt_delayed_handler(void *param) } /* restore original mask */ - intr->mask_misc |= TXGBE_ICRMISC_LSC; + if (dev->data->dev_conf.intr_conf.lsc == 1) + intr->mask_misc |= TXGBE_ICRMISC_LSC; intr->mask = intr->mask_orig; intr->mask_orig = 0; -- 2.27.0